Repository navigation
Conversation
updateProtPool raises an error on every ecModel made with GECKO 3.2.0 or later; setProtPoolSize sets the protein pool for a condition. mergeDLKcatAndFuzzyKcats is a wrapper of mergeKcats. Both move to src/deprecated and print a deprecation warning. truncateValues had no caller in src.
createGECKOproject warns when it writes an adapter class, and adapterTemplate.m moves to src/deprecated. model_adapter.toml configures GECKO and geckopy; adapter classes still load, and convertAdapterToToml converts them.
kcatsFromDLKcat gets the option via: 'okp' predicts with the DLKcat method of OpenKineticsPredictor, 'file' reads data/DLKcat.tsv and 'docker' runs DLKcat locally in its Docker image. Without data/DLKcat.tsv the default is 'okp', so the presets gecko_median and gecko_classic no longer need Docker. updateKcatSources reports a dlkcat source as pending while its OKP job runs. 'run', true still selects the Docker run.
The GECKO repository ignores okpApiKey.txt, and createGECKOproject writes a .gitignore with data/okpApiKey.txt in a new project. The help of resolveOkpApiKey said the file was ignored, which was not the case.
Adds tc0701-tc0704 to geckoCoreFunctionTests so CI runs them.
The column sucrose (r_2058) appeared twice with the same values in every row.
A project that does not set [uniprot] id and [kegg] id no longer gets the identifiers of Saccharomyces cerevisiae. loadDatabases raises loadDatabases:noUniprotID when data/uniprot.tsv is missing and the UniProt identifier is empty; an empty KEGG identifier skips KEGG with a warning, as before. adapterTemplate.toml writes empty identifiers with examples.
This was referenced Nov 12, 2026
Unit test results105 tests 105 ✅ 18s ⏱️ Results for commit 2158fa2. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes take GECKO 3 steps that GECKO 4 replaced out of the usual workflow, and align MATLAB with geckopy. They are grouped because the rewritten guide (CompMetEng/gecko-docs#44) describes them together. geckopy: CompMetEng/geckopy#92. Parity ledger: CompMetEng/raven-gecko-parity#155.
Main improvements in this PR:
updateProtPool,mergeDLKcatAndFuzzyKcats: no longer part of the workflow (updateProtPoolfailed on every ecModel made with GECKO 3.2.0 or later); moved tosrc/deprecatedwith a deprecation warning.truncateValues: removed; nothing called it.applyCustomKcats: replaced bydata/kcats/custom.tsv; moved tosrc/deprecated.collectKcatsandassignKcatsraisecollectKcats:legacyCustomKcatson a project that has onlydata/customKcats.tsv, and nameconvertCustomKcats.runDLKcat,writeDLKcatInput,readDLKcatOutput: local functions ofkcatsFromDLKcat('via', 'docker'and'via', 'file'). The stubs insrc/deprecatedwarn;runDLKcatandwriteDLKcatInputthen raise an error that nameskcatsFromDLKcat, whilereadDLKcatOutputstill reads its file.bayesianSensitivityTuning, its helpersabc_max,getrSampleandupdateprior, andgetcarbonnumandfindMaxValue: stubs that raiseGECKO:removedFunctionand name the replacement (cmaesKcatTuning,fillCarbonNum,kcatsFromBrenda).createGECKOprojectwarns when it writes one, the first adapter class loaded in a MATLAB session warnsGECKO:deprecatedAdapterClassunless it subclassesTomlAdapter, andadapterTemplate.mmoves tosrc/deprecated;model_adapter.tomlconfigures GECKO and geckopy, andconvertAdapterToTomlconverts a class.setProtPoolSize: did nothing on a model withoutprot_pool_exchange; it now raisessetProtPoolSize:noPoolExchange.sigmaFitter: accepted a target growth rate of 0 or below; it now raisessigmaFitter:growthRate.flexibilizeEnzConcs: could lower an existing higher bound and ran without an iteration cap whenperComplexwas off; on an infeasible input it returned an empty result silently, and now warnsflexibilizeEnzConcs:infeasible.getConcControlCoeffs: continued after a first solve that was not optimal; it now raises an error.relaxProteomicsGreedy: raised the iteration error even when the last allowed relaxation reached the target; it also returns the relaxed model as second output.getComplexData: without a taxonomic id it failed with "output not assigned"; it now warns and returns an empty result.loadConventionalGEM: thefilenameoption appended.xmlto a.ymlname.kcatsFromDLKcat: optionvia('okp','file','docker'); withoutdata/DLKcat.tsvit predicts with the DLKcat method of OpenKineticsPredictor, so the presetsgecko_medianandgecko_classicno longer need Docker. It returns[kcatList, done].kcatsFromOKP: the OpenKineticsPredictor engine (submitOpenKineticsPredictor,fetchOpenKineticsPredictor,writeOpenKineticsPredictorInput,readOpenKineticsPredictorOutput) became local functions;resolveOkpApiKeystays public.okp.method,[kcat_sources.okp] methods: the default is KinForm-H alone (was CataPro, and eight methods for the presets).relaxEnzConcs: new; finds the least total relaxation of the measured enzyme concentrations in one LP, as geckopyrelax_enz_concs.constrainEnzConcs: optionrestrictTo, as geckopy.getConcControlCoeffs: optionmethod('finite_difference','shadow_price'), as geckopy.[uniprot] id,[kegg] id: defaulted to the identifiers of Saccharomyces cerevisiae, so a project for another organism silently downloaded yeast data. They are now empty;loadDatabasesraisesloadDatabases:noUniprotIDwhendata/uniprot.tsvis missing, and an empty KEGG identifier skips KEGG with a warning.kcatDecisions.tsv: column names are snake_case, as geckopy writes them.createGECKOproject: writes a.gitignorewithdata/okpApiKey.txt; the GECKO repository ignores the file too.[kcat_sources.<name>]: a table replaced the preset's settings for that source; it now overrides only the keys it sets.cmaesKcatTuning,screenKcatLeverage: failed further on without any evotune data file; they now raiseevotune:noData. A source in several trust groups took the last group; it now takes the first, as geckopy.ecFSEOF: failed with an index error when production had no range to scan; it now raisesecFSEOF:noRange.downloadUniProt: kept only reviewed entries, against the adapter defaultuniprot.reviewed = false.loadAdapterParams: replaced an empty adapter value with the default.findMetSmiles: queried PubChem for empty metabolite names.sensitivityTuning: printed light-model progress after the target check, and printed "No growth increase" without theWARNING:label.upgradeGECKOproject: pointed calls toupdatepriortoupdatePrior, which does not exist; it now namescmaesKcatTuning, and also lists calls to the other removed GECKO 3 functions.constrainEnzConcs(pool use),getPfbaEnzymes(field name),getEnzymeUsage(capacity usage),reportEnzymeUsage(threshold),ecFSEOF(three output files),makeEcModel(light model),findMetSmiles(cache path),fuzzyKcatMatching(closest organism),convertCustomKcats(error message).fuzzyKcatMatching,assignKcatValues,mergeKcats,getKcatAcrossIsozymes,getStandardKcat,removeStandardKcat: marked low-level in their help.sensitivityTuningandcmaesKcatTuningare named the standard and the advanced kcat tuning.tutorials/full_ecModel,tutorials/light_ecModel: protocols rewritten for GECKO 4 without the GECKO 3 protocol steps. Both assign kcats with thebrenda_ec_treepreset from shipped files indata/kcatsand need no OpenKineticsPredictor key; models and outputs are regenerated. Stray files andHumanGEMAdapter.mare removed.Instructions on merging this PR:
developas target branch, and will be resolved with a squash-merge.mainas target branch, and will be resolved with a merge commit.