Fix frozen grouped headers on horizontal scroll#4098
Open
clmentcoutet wants to merge 2 commits into
Open
Conversation
|
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4098 +/- ##
==========================================
+ Coverage 97.54% 97.55% +0.01%
==========================================
Files 39 39
Lines 1588 1596 +8
Branches 515 519 +4
==========================================
+ Hits 1549 1557 +8
Misses 39 39
🚀 New features to boost your workflow:
|
Grouped column header cells never applied horizontal-freeze styling, so a group whose child columns are frozen scrolled away instead of sticking to the edge (Comcast#3531). CalculatedColumnParent now carries a frozen state folded from its children (frozen only when every child sits in the same frozen band), and GroupedColumnHeaderCell reuses getCellStyle/getCellClassname like the leaf HeaderCell so the sticky offset and frozen classes are applied.
Add a scroll assertion for grouped headers whose children share a frozen band, so the regression is covered by behavior rather than classes alone. Expose start- and end-frozen column groups in the Column Grouping website demo for manual testing with npm run start.
clmentcoutet
force-pushed
the
fix/3531-frozen-grouped-header
branch
from
b451b2d to
ef78730
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue #3531
Fixes grouped column headers so they stay pinned during horizontal scrolling when all child columns belong to the same frozen band.