Skip to content

Upgrade Node support to 26 - #1541

Open
ekwav-agent wants to merge 1 commit into
Coflnet:mainfrom
ekwav-agent:ekwav-agent/task_4w6hlwlrlfsn6zjbwfzq
Open

Upgrade Node support to 26#1541
ekwav-agent wants to merge 1 commit into
Coflnet:mainfrom
ekwav-agent:ekwav-agent/task_4w6hlwlrlfsn6zjbwfzq

Conversation

@ekwav-agent

Copy link
Copy Markdown
Contributor

Automated patch from task task_4w6hlwlrlfsn6zjbwfzq.

Base branch: main
Base commit: d6ccd925320dc92fd7e0f5d6c4c61308b5553f94

Review: separate codex session recorded.

WARNING: review uses a separate session of the same provider; it is not an independent-provider review

Tests:

  • node_26 — sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
  • npm_ci — sha256:a45fa951e7ea5888790c9c2fb712a711488e63179ba8422f7a2d7a19350968b8
  • production_build — sha256:425afaa0e7f3c2719651050a883de823825b3a81f31a43db87bb59ea744d8e85
  • test_server_ready — sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
  • cypress_auction_cy_ts — two head attempts, base replay for triage: head_exit=0 head_log_sha256=fbe1f70c750fc34dfb67f4c9a17f4688cde2f72efb3e380465ffa89fc73750f3
  • cypress_crafting-utils_cy_ts — two head attempts, base replay for triage: head_exit=0 head_log_sha256=66451ac9b7b6028e62edf481b9f0dc2e23f0850a9fbf9bad47ce15e74cb8f3ef
  • cypress_crafts_cy_ts — two head attempts, base replay for triage: head_exit=0 head_log_sha256=b1bb5ad33821181697a432d092d5c08c4e53b53a0226b8bc027a32ba65baa599
  • cypress_filter_cy_ts — two head attempts, base replay for triage: head_exit=0 head_log_sha256=33e7078cb1a361087d208e17b7a7b0a6d87608d3648d48c25ef72c39f0dd71c3
  • cypress_forge_cy_ts — two head attempts, base replay for triage: head_exit=0 head_log_sha256=639b417e6847c2370e46d3edc48855c34f0223e54eb5b88d7baf5ba8e69dc7b0
  • cypress_generated-api-response-utils_cy_ts — two head attempts, base replay for triage: head_exit=0 head_log_sha256=b1471de1299a580a1bfbd8ccbe9c83b555254d399591a3df448deba665b697db
  • cypress_item-redirect-utils_cy_ts — two head attempts, base replay for triage: head_exit=0 head_log_sha256=7fc15ee582ba4ec8ccaed49ffc539a442bfc0be717cd6e6a0742bd4e2487c2a4
  • cypress_player_cy_ts — two head attempts, base replay for triage: head_exit=0 head_log_sha256=8ab25f3a9a6addfc57061554839c8fec46452cb2a619e76067435ea36348cb3b
  • cypress_search_cy_ts — two head attempts, base replay for triage: head_exit=0 head_log_sha256=aab1c1b0b0030403eff8d3af67355733af837fc7a38714a5f146418328033e52
  • cypress_year-view_cy_ts — two head attempts, base replay for triage: head_exit=0 head_log_sha256=ad9f8924881ff6d719c881f1c229b5b0545367aac0d83139ec485b775887934b
  • authenticated_year_view_personas — fixed synthetic test identities 1=free, 2=paid, 3=second paid control; free-versus-paid year-history only; premium-plus distinction not tested; credential-free test-only stub; network-none browser; no browser artifacts

Fixed the trusted-gate failure without weakening tests.

  • Reproduced the exact crafting-utils.cy.ts webpack error: JSX from Formatter.tsx entered a plain TypeScript Cypress bundle.
  • Moved the unchanged acquisition-planning logic into utils/AcquisitionUtils.ts.
  • CraftingUtils.ts now imports the pure utility directly.
  • Formatter.tsx re-exports the same API, preserving existing callers and behavior.

Validation on Node 26.8.1:

  • npm ci: passed.
  • Production build: passed.
  • Focused utility lint: passed.
  • crafting-utils.cy.ts: previously failed during compilation; now passes with 1 test.
  • Full Cypress run: corrected regression and six other specs passed. Three production-data specs failed intermittently after retry; the trusted gate previously demonstrated these pass/fail independently of this pure import correction and will replay failures against base.

No authentication, billing, player-data, GitOps, deployment, or test behavior was changed.

This PR cannot be merged or approved by the automation identity; human review is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant