Skip to content

Fix #441: config loading failed - #442

Open
ekwav-agent wants to merge 1 commit into
Coflnet:mainfrom
ekwav-agent:ekwav-agent/task_enzuos4xer7n77jhrgwq
Open

Fix #441: config loading failed#442
ekwav-agent wants to merge 1 commit into
Coflnet:mainfrom
ekwav-agent:ekwav-agent/task_enzuos4xer7n77jhrgwq

Conversation

@ekwav-agent

Copy link
Copy Markdown
Contributor

Automated patch for #441 from task task_enzuos4xer7n77jhrgwq.

Base branch: main
Base commit: 68aa16ce4929f7adfbf350546b23bcfa0a9165ce

Review: separate codex session recorded.

WARNING: review uses a separate session of the same provider; it is not an independent-provider review

Tests:

  • container_build — sha256:a0170a335e47768ba4b14dadae4cdc748925b618f9f8472fbe52621754ceec33
  • regression_base_fail_patch_pass — trusted-harness exact command, isolated checkout servers, and reviewed test overlays: overlay_derivation=applied:1 sibling_setup_exit=0 overlay_setup_exit=0 overlay_review_digest=unavailable overlay_receipt_sha256=unavailable base_setup_exit=0 base_setup_log_sha256=unavailable server_isolation_exit=0 base_exit=1 base_log_sha256=455f432599f0298f8820df8563678ca70d4ae0073d184520bb793fa444a46f8b patched_exit=0 patched_log_sha256=fbed76f077f4cf2c2a94089aab7a71cf2e9e9140a49f64e7c04c70bf3cea90be

Fixed config loading when account details are temporarily absent after load. Config statistics now fall back to the authenticated socket user ID instead of throwing.

  • Added focused regression coverage in SessionFilterState.Tests.cs.
  • Base: regression fails with NullReferenceException.
  • Patch: regression passes.
  • Required docker build --pull --tag coflnet-sky-mod-commands-test . passes.
  • Authentication, payments, permissions, tracing, and player-data scope remain unchanged.

Production trace 30209005c3242c7db13a22889dd49094 and its bounded log lookup both returned Jaeger ServiceUnavailable, so exact production stack verification was unavailable. The screenshot nevertheless confirms the error occurs after config loading, matching the regression’s post-load path.


The reviewer also noted the following, which this patch is not responsible for and did not change:

  • Exact production causality remains unverified because the referenced Jaeger trace was unavailable, so the diagnosis relies on the bounded screenshot and repository-only regression.

This PR cannot be merged or approved by the automation identity; human review is required.

@ekwav-agent
ekwav-agent requested a review from Ekwav August 27, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant