feat(cli): load rules database from file - #78
Open
alexsmolya wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Fixes #68
diskern scancan now accept an optional external rules database:Without
--rules, the CLI continues to use the embedded rules database. A supplied file is deserialized through the existingRulesDbmodel, with explicit errors for unreadable files and malformed JSON. Human-readable output identifies the external rules source, while JSON output remains valid on stdout. The change stays at the CLI boundary and does not move classification logic out ofdiskern-core.The user-visible feature is documented in
CHANGELOG.md.Validation
cargo fmt --allcargo +1.96.0 clippy -p diskern-core -p diskern-cli --all-targets -- -D warningscargo +1.96.0 test -p diskern-core -p diskern-cligit diff --checkAll passed. The focused suite includes regression coverage for embedded rules, valid external rules, missing files, and malformed JSON.
Checklist
cargo fmt --alland the required core/CLI clippy validation are clean