Repository navigation
Config: pin the automatic browser-access default - #302
Merged
Merged
Conversation
Guard the security-relevant ENGRAPHIS_BROWSER_AUTO_SESSION default (on) and its off switches, including the malformed-value fallback. The configuration and Playwright comments now describe the shipped behavior: token-protected API routes, automatic browser access.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Three small gaps left after the automatic browser-access change:
ENGRAPHIS_DASHBOARD_URL's row did not mention that its host now also authorizes automatic browser sessions.What changed
test_browser_auto_session_defaults_on_and_can_be_hardened: asserts the default is on, that0/false/off/noharden it, and that a malformed value keeps the documented default instead of flipping the access posture.docs/CONFIGURATION.md: theENGRAPHIS_DASHBOARD_URLhost is accepted by the/mcpguard, automatic dashboard browser access, and the token-free API.playwright.config.js: comment now says token-protected API routes with automatic browser access (the fixture token itself is unchanged and still not an owner credential).Verification
python -m pytest tests/test_config.py -q(passes)ruff check tests/test_config.py