fix: roll back failed resource imports completely - #207
Open
Coding-Dev-Tools wants to merge 2 commits into
Open
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d295e1971
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix resource imports that report a failed file while committing part of it. For example, an FTS failure on the second file of a three-file import previously returned two imports and one error but retained all three canonical records. A later chunk or optional derived fact could also leave an unreported prefix.
Folder and upload imports now roll back each failed resource's chunks, vectors, FTS and receipts before returning its error. Optional derivation has an independent rollback boundary that preserves the successfully imported source. Failed savepoint rollback/release raises a fatal
SavepointError; the enclosing operation aborts, including optional conflict repair. Caller-owned work remains caller-owned, and native index writes participate in rollback.Depends on #206 (and #203) and targets
codex/memory-maintenance-boundaries. No schema migration, public response/signature, ranking or approval changes. This is the integrity prerequisite for moving legacy import preparation outside the writer; that preparation and separate-index post-commit publication remain separate work. Earlier partial imports are not automatically erased or reconciled.Type
Verification
dc4382d1; the preserved original regression run has 10 passes and two optional native skips.ruff check .passes.6638196f, including Python 3.9 core, full-stack 3.10-3.14, encryption, coverage, browser, package, integration and Docker gates.7d295e19; the final follow-up changes only the test fixture.