Repository navigation
fix: review findings from #88 - #90
Merged
Merged
Conversation
…nks root-absolute
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the five CodeRabbit findings on #88, each with a test that fails before the fix:
dilated-powerrunspsunderLC_ALL=C, so the app and the repair agent agree on a process's start time. A locale difference could mark a live closed-lid session dead and revert it.beattakes the lock and usestouch -c, so it can't recreate a sessionrepairjust removed.DownloadTarget.systemDownloads()is deleted. It was dead code, and its entitlement was dropped in feat(website): privacy policy page; drop unused MAS entitlements #87./privacy/308s to/privacy, and the page's links are root-absolute.The bundled companion copy of the script and its SHA constant are updated to match. The hardware repair-agent check passes again on this Mac.