Skip to content

fix: review findings from #88 - #90

Merged
scttbnsn merged 4 commits into
dev/m2from
fix/review-88
Nov 4, 2026
Merged

scttbnsn merged 4 commits into
dev/m2from
fix/review-88

Conversation

@scttbnsn

@scttbnsn scttbnsn commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Fixes the five CodeRabbit findings on #88, each with a test that fails before the fix:

  • dilated-power runs ps under LC_ALL=C, so the app and the repair agent agree on a process's start time. A locale difference could mark a live closed-lid session dead and revert it.
  • beat takes the lock and uses touch -c, so it can't recreate a session repair just removed.
  • The publish guard only counts release directories with a valid manifest for that version as retained history.
  • DownloadTarget.systemDownloads() is deleted. It was dead code, and its entitlement was dropped in feat(website): privacy policy page; drop unused MAS entitlements #87.
  • /privacy/ 308s to /privacy, and the page's links are root-absolute.

The bundled companion copy of the script and its SHA constant are updated to match. The hardware repair-agent check passes again on this Mac.

@coderabbitai

coderabbitai Bot commented Nov 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e19fb8fa-5b4a-4574-89a2-f03a231b82ba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@scttbnsn
scttbnsn merged commit 1aabd60 into dev/m2 Nov 4, 2026
2 of 3 checks passed
@scttbnsn
scttbnsn deleted the fix/review-88 branch November 4, 2026 00:39
@codecov

codecov Bot commented Nov 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant