Repository navigation
feat(mas): compile out donate, CLI install, process triggers, helper migration and update controls - #76
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MAS slice BUILD.2. The App Store build (
DILATED_CHANNEL=mas) now compiles out the donate links, CLI install, process-by-name triggers, the old helper migration and the Sparkle update controls. In that build, the update status reads "Updates come from the Mac App Store." Saved process rules still decode there but never match, and the persisted format doesn't change. The direct build behaves the same as before.Also fixes
check-mas-build.sh, which looked for the binary at a path this toolchain doesn't use, and makes it executable. CI runs the MAS build and theMASChanneltests after verify, and the job timeout goes to 25 minutes to fit them. Covers both CodeRabbit minors from #75.