Repository navigation
fix(helper): recheck normal sleep after confirming a notFound helper is gone - #24
Merged
Merged
Conversation
…is gone The helper-absence check can take seconds, so removal now re-reads power before reporting success, like the unregister path.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeRabbit on promotion PR #23: the
.notFoundremoval path read power, then awaited the helper-absence check (launchctl plus pgrep, which can take a few seconds), and then reported success. If sleep-disable changed during that check, removal succeeded on a stale reading. It now re-reads power after the check before invalidating, the same way the unregister path does.Verify:
bash scripts/verify.shpasses. A new ClosedLidControllerTests case returns normal sleep on the first read and sleep-disabled on the second, and removal is refused with no unregister call and the lease kept. It failed before the change.