Skip to content

build(mas): promote the 1.0 store submission - #115

Merged
scttbnsn merged 1 commit into
mainfrom
dev/m2
Nov 13, 2026
Merged

scttbnsn merged 1 commit into
mainfrom
dev/m2

Conversation

@scttbnsn

Copy link
Copy Markdown
Contributor

Promote the reviewed store submission fixes from dev/m2 to main. The MAS package uses readable provisioning profiles and a numeric display version, validates its signed bundle, and exposes the privacy policy in About. The website adds the optional closed-lid companion download page. The existing direct beta.13 release stays published.

PR #114 passed both Swift CI jobs, patch coverage, current non-author approval and CodeRabbit's incremental review through 74090d1 with no new findings. The profile permission regression and privacy link tests failed before their fixes and pass now. The signed source package passed Apple validation.

After this promotion passes its required checks and approval, tag the exact main source, rebuild and validate build 18, then upload it to App Store Connect for TestFlight verification and App Review. This does not mark the direct-channel GA acceptance checks passed.

* fix(mas): prepare readable store release bundles

* feat(mas): add the closed-lid companion download page

* fix(mas): check every permission class for bundle reads

* fix(mas): expose the privacy policy from About
@coderabbitai

coderabbitai Bot commented Nov 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 57 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e5c42ad1-dead-4522-8da2-df7275c56cc3
Commits

Reviewing files that changed from the base of the PR and between b82fbca and ca4a56b.

Files ignored due to path filters: 2

  • website/dist/closed-lid-setup.html is excluded by !**/dist/**
  • website/dist/index.html is excluded by !**/dist/**
Files selected for processing: 7

  • Sources/DilatedUI/Settings/AboutSettings.swift
  • Tests/DilatedUITests/AboutSettingsTests.swift
  • Tests/ReleaseTests/test_check_mas_bundle.py
  • docs/RELEASING.md
  • scripts/build-mas.sh
  • scripts/check-mas-bundle.py
  • website/vercel.json
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@biggest-littlest biggest-littlest left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The promotion contains the exact tree reviewed and tested in #114. Both source CI jobs, coverage and the current CodeRabbit review passed; the signed package passed Apple validation. Approve this source promotion, with required promotion CI still mandatory before merge.

@codecov

codecov Bot commented Nov 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@scttbnsn
scttbnsn merged commit 0e2c40f into main Nov 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants