Skip to content

fix(build): preserve isolated state during dev verification - #107

Closed
scttbnsn wants to merge 1 commit into
dev/m2from
fix/dev-verify-isolation
Closed

scttbnsn wants to merge 1 commit into
dev/m2from
fix/dev-verify-isolation

Conversation

@scttbnsn

@scttbnsn scttbnsn commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

The dev verification script used the requested isolated state for its CLI but launched the app without it. Pass DILATED_STATE_DIR explicitly through open --env so both processes use the same state directory, including paths with spaces. Normal launches are unchanged.

The new regression failed before the fix and all 12 build/run tests pass afterward. Full verification passed 700 Swift tests, 106 release tests, 16 MAS bundle checks and the website checks; scoped Qlty passed. Two real build/verify runs used private state: PID 76008 was replaced by PID 76203, both answered the isolated CLI, and cleanup confirmed the owned process exited. Shared SleepDisabled stayed Yes throughout. No sleep, reboot, uninstall or administrator prompt was attempted. This stays separate from the prepared beta.12 scope.

@coderabbitai

coderabbitai Bot commented Nov 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0c9a1566-8466-4ec4-8e75-6d161ea0e653

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@biggest-littlest biggest-littlest left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the isolated-state handoff and regression. The state directory reaches open as a single environment argument, including spaces; default launches retain their previous arguments. The isolated CLI and app now agree. The regression failed before the fix; all 12 build/run tests and full verification pass. The real two-process restart and cleanup receipt preserves shared sleep-disable state. First CodeRabbit review and current CI remain required.

@codecov

codecov Bot commented Nov 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@scttbnsn

scttbnsn commented Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

Delivered through #109, now merged into dev/m2 for beta.12. The combined review and CI cover these changes and their follow-up fixes.

@scttbnsn scttbnsn closed this Nov 7, 2026
@scttbnsn
scttbnsn deleted the fix/dev-verify-isolation branch November 7, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants