Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
biggest-littlest
left a comment
There was a problem hiding this comment.
Checked the isolated-state handoff and regression. The state directory reaches open as a single environment argument, including spaces; default launches retain their previous arguments. The isolated CLI and app now agree. The regression failed before the fix; all 12 build/run tests and full verification pass. The real two-process restart and cleanup receipt preserves shared sleep-disable state. First CodeRabbit review and current CI remain required.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Delivered through #109, now merged into dev/m2 for beta.12. The combined review and CI cover these changes and their follow-up fixes. |
The dev verification script used the requested isolated state for its CLI but launched the app without it. Pass DILATED_STATE_DIR explicitly through open --env so both processes use the same state directory, including paths with spaces. Normal launches are unchanged.
The new regression failed before the fix and all 12 build/run tests pass afterward. Full verification passed 700 Swift tests, 106 release tests, 16 MAS bundle checks and the website checks; scoped Qlty passed. Two real build/verify runs used private state: PID 76008 was replaced by PID 76203, both answered the isolated CLI, and cleanup confirmed the owned process exited. Shared SleepDisabled stayed Yes throughout. No sleep, reboot, uninstall or administrator prompt was attempted. This stays separate from the prepared beta.12 scope.