[scttbnsn]

Local Qlty reported 28 ShellCheck findings because it could not follow the shared MAS check library. Allow source analysis, document the library's shared outputs at the affected assignments, remove an unused directory flag, and use bounded arithmetic polling loops. Preflight checks and power commands are unchanged.

Validation: full scripts/verify.sh passed 700 Swift tests, 105 release tests, 16 MAS bundle checks and the website checks. Local qlty check --all and direct ShellCheck both report no issues. The live power-changing scripts were not run. This stays separate from the prepared beta.12 release scope.

Summary by CodeRabbit

• Chores
  • Updated shell-script checks and streamlined internal setup and polling logic. The existing retry counts, timing, and resulting behavior remain unchanged.
  • No user-facing features or behavior changes are included in this update.

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

The changes update ShellCheck settings and annotations in the MAS check scripts. They also replace seq-based polling loops with Bash arithmetic loops while keeping the same retry counts and polling behavior.

Changes: MAS check script updates

Layer / File(s)	Summary
ShellCheck configuration and shared state .shellcheckrc, scripts/closed-lid-setup-check.sh, scripts/mas-check-lib.sh	External source loading is enabled. ShellCheck comments are updated, and created_scripts_dir tracking and one suppression comment are removed. The rmdir operation remains unchanged.
Arithmetic polling loops scripts/mas-crash-revert-check.sh	The polling loops in launch_app, quit_app, and seed_settings use Bash arithmetic loops. Their retry counts and polling behavior remain unchanged.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

• CodesWhat/dilated#88: Adds the MAS check library and live-check scripts updated in this pull request.

Merge Risk: Minimal · up to 0237e

The changes target script analysis and polling-loop syntax; no merge-blocking issue is established.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly summarizes the MAS script analysis changes.
Docstring Coverage		Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 5 functions across 2 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate docstrings

• Commit to this branch
• Create a new PR

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: e0443410-8e61-4b15-93c6-e7ab1ff7d987

Commits

Reviewing files that changed from the base of the PR and between 7460322 and 0237ee3.

Files selected for processing: 4

• .shellcheckrc
• scripts/closed-lid-setup-check.sh
• scripts/mas-check-lib.sh
• scripts/mas-crash-revert-check.sh

Files with no reviewable changes: 1

• scripts/closed-lid-setup-check.sh

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

[biggest-littlest]

Checked the shared-library analysis change and polling bounds. ShellCheck follows the source library; the narrow annotations describe state consumed by callers. The unused directory flag has no reads, and the arithmetic loops retain their original attempt counts. No preflight, power command or cleanup path was changed. Full verification and local Qlty passed. First CodeRabbit review and current CI remain required.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[scttbnsn]

@coderabbitai review

Review current head 0237ee3. This is a single-user local macOS app; this diff changes maintainer script analysis. Check source-following configuration, the shared-state annotations, removal of the unread directory flag and equivalent polling bounds. Power commands and preflight checks should stay unchanged.

[coderabbitai]

Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[scttbnsn]

Delivered through #109, now merged into dev/m2 for beta.12. The combined review and CI cover these changes and their follow-up fixes.