Repository navigation
fix(rendering): draw triplet feel once per bar and capo once per staff - #2992
Merged
Merged
Conversation
The triplet feel indication was created for every voice and every staff of a bar, the capo text for every voice. Both now follow the guards used by tempo and marker effects. Fixes #2973
6 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
AI-authored disclosure (
alphatab-ai-authored-v1)Portions of this content were authored by an AI agent. The agent has read
AGENTS.md and the human submitter accepts responsibility for
compliance with the rules in that document.
Issues
Fixes #2973
Proposed changes
Effect bands are created per voice, and
TripletFeelEffectInfoonly checked for the first beat of the bar. Every voice therefore drew its own triplet feel indication, and on multi-staff tracks (e.g. piano) every staff did as well.CapoEffectInfohad the same per-voice duplication.Like tempo and markers, the triplet feel is not shown in a system where staff 0 is hidden (e.g.
hideEmptyStaves). This is an existing limitation of all system-level effects and is better solved for all of them together.A new visual test covers two voices and two staves with a triplet feel change and a different capo per staff. No existing reference changed.
Checklist
AI authorship disclosure
(
alphatab-ai-authored-v1) is present at the top of this body, and I havepersonally reviewed every change and can explain each one
Further details