Skip to content

Manchester | Monsur Abdulrahman | 26-ITP-Sep | Sprint 1 | Format-clock-edge-cases #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Monsur0001 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Manchester | Monsur Abdulrahman | 26-ITP-Sep | Sprint 1 | Format-clock-edge-cases #1725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1bca3ce
fix: update formatAs12HourClock function to handle edge cases and add…
Monsur0001 Oct 17, 2026
59ecb2b
Add leading zero for a single digit
Monsur0001 Oct 17, 2026
8d645cd
refactor: improve formatting logic and clean up test cases for time c…
Monsur0001 Oct 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions format-clock-edge-cases/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,4 @@ function formatAs12HourClock(time) {
```

It still has bugs. Think of as many edge-cases as you can with this code. Write tests for all of them, and fix this code so that it works correctly for all valid inputs. You don't need to worry about invalid inputs (e.g. `"25:00"`).

16 changes: 15 additions & 1 deletion format-clock-edge-cases/timeConverter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,24 @@
function formatAs12HourClock(time) {

const hours = Number(time.slice(0, 2));
const minutes = time.slice(3, 5);

if (hours > 12) {
return `${hours - 12}:00 pm`;
const convertedHours = hours - 12;
// Add leading zero if convertedHours is a single digit
const formattedHours = convertedHours < 10 ? `0${convertedHours}` : convertedHours;

@hackertainment hackertainment Oct 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this produces a correct result, it would be a best practice to assign the same type of data to a variable (rather than leaving it to the JavaScript interpreter for type conversion), i.e. ? `0${convertedHours}` : `convertedHours`; so that both values are of the string type.

return `${formattedHours}:${minutes} pm`;
}
//handling noon.
if (hours === 12) {
return `12:${minutes} pm`;
}

//handling midnight
if (hours === 0) {
return `12:${minutes} am`;
}
//handling morning times
return `${time} am`;
}

Expand Down
22 changes: 22 additions & 0 deletions format-clock-edge-cases/timeConverter.test.js
View file
Open in desktop

@hackertainment hackertainment Oct 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test cases you have included are:

  • 00:00 midnight
  • 12:00 noon
  • 01:30 single digit hour in the morning
  • 13:45 single digit hour in the afternoon
  • 23:00 double digits hour in the afternoon

It seems that there is still one case missing. Please add it back, thanks a lot.

Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,25 @@ test("correctly convert time after 12:00", function(){
test("can correctly convert morning time", function() {
assert.equal(formatAs12HourClock("08:00"), "08:00 am");
});


test("correctly convert midnight", function() {
assert.equal(formatAs12HourClock("00:00"), "12:00 am");
});

test("correctly convert noon", function() {
assert.equal(formatAs12HourClock("12:00"), "12:00 pm");
});

test("correctly convert single digit hour in the morning", function() {
assert.equal(formatAs12HourClock("01:30"), "01:30 am");
});

test("correctly convert single digit hour in the afternoon", function() {
assert.equal(formatAs12HourClock("13:45"), "01:45 pm");
});

test("correctly convert time with leading zeros", function() {
assert.equal(formatAs12HourClock("09:05"), "09:05 am");
});

Loading