Cape Town | sep-2026-ITP | Matthaus Bause | Sprint 2 | Implement and rewrite tests

[chefmatthaus-hub]

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Task code

CYF-1059

[hackertainment]

The code generally looks good to me. Just need to fix test cases for proper fraction. Your are almost there, and keep it up :-)

[hackertainment]

It seems to me that there are redundant and missing test cases:

• About zero cases, you have tested (0, 1) (1, 0) and (-1, 0) but missed a case.
• About non-zero (numerator≠denominator) case, you have included (-1, -2) (1, -2) (-1, 2) and (1, 2) but they are all numerator less than denominator (if not considering the negative sign). How about numerator greater than denominator with negative numbers? Since (9, 8) (4, 2) (5, 3) (6, 4) (7, 1) (15, 14) are all testing the same scenario, there would be 3 other combinations missing.
• About non-zero (numerator=denominator) case, you have tested positive number (4, 4) but missed the negative number.

So please add the missing cases (and optionally remove redundant cases as well). Thank you.

[hackertainment]

Same comment as https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/pull/1685/changes#r4308748253
Please add the missing cases (and optionally remove redundant cases as well). Thank you.