Birmingham | 26-ITP-May | Toluwalase Tiamiyu | Sprint 3 | Coursework#1447
Open
TTiamiyu wants to merge 7 commits into
Open
Birmingham | 26-ITP-May | Toluwalase Tiamiyu | Sprint 3 | Coursework#1447TTiamiyu wants to merge 7 commits into
TTiamiyu wants to merge 7 commits into
Conversation
…types and invalid cases
…ases and various scenarios
TTiamiyu
added
🏕 Priority Mandatory
LonMcGregor
reviewed
Jul 8, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, just one minor comment from me
|
|
||
| function isProperFraction(numerator, denominator) { | ||
| // TODO: Implement this function | ||
| if (denominator === 0) { |
There was a problem hiding this comment.
Is there a way you could combine this condition with the one below?
Author
There was a problem hiding this comment.
Hi, could you please clarify the comment for me, do you mean combining it with the "module.exports = isPropperFraction" ?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Questions
None