London | 26-ITP-May | Dipa Sarker | Sprint 2 | Coursework

[Dipa-Sarker]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

1. Errors

• Predicted errors in each file in the errors section
• Ran each file using Node.js
• Explained why each error occurs

2. Debug

• Predicted why each program was not working
• Ran files with Node.js to confirm issues
• Fixed bugs in the code

3. Implement

• Implemented required functions:
  • BMI calculator
  • Case conversion function
  • Pounds conversion function
• Tested each function with multiple inputs

4. Interpret

• Analyzed the given program
• Used documentation to understand unfamiliar syntax
• Used console.log to verify variable values

5. Extend

• Wrote additional tests for edge cases
• Fixed bugs found during testing of 24-hour to 12-hour conversion

[LonMcGregor]

Good work, there is just one question I have about brackets - you can see my comment in one place where you use brackets that are maybe not needed. See if you can spot the other locations throughout your code.

[LonMcGregor]

Do you need to use brackets here?

[Dipa-Sarker]

Thank you for your observation. Yes, I agree with you, there is no need to use brackets here cause this is a simple expression which will not affect the result without bracket. I made correction in the code.

[LonMcGregor]

Good work finding these. Are there any other examples of brackets that are not needed in your other files?

[Dipa-Sarker]

I have tried to make corrections for other files. If anything else needed please let me know. Thank you.

[LonMcGregor]

Good work, this task is complete now