Manchester | ITP-MAY-2026 | Yee Man Tsang | Sprint 2 | Coursework/Sprint-2 by lintsang · Pull Request #1416 · CodeYourFuture/Module-Structuring-and-Testing-Data

lintsang · 2026-06-27T15:43:17Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Finished all exercises in all folders in sprint 2

cjyuan · 2026-07-02T01:19:13Z

 function calculateBMI(weight, height) {
-    // return the BMI of someone based off their weight and height
-}
+    return (weight / height**2).toFixed(1);


What type of value do you expect your function to return? A number or a string?
Does your function return the type of value you expect?

Different types of values may appear identical in the console output, but they are represented and treated differently in the program. For example,

console.log(123); // Output 123 console.log("123"); // Output 123 // Treated differently in the program let sum1 = 123 + 100; // Evaluate to 223 -- a number let sum 2 = "123" + 100; // Evaluate to "123100" -- a string.

Thanks for reminder. I learnt that the types of value should be carefully considered when I am writing the code.

cjyuan · 2026-07-02T01:20:30Z

 // This might help https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toUpperCase
+
+function UPPER_SNAKE_CASE(string){
+    upperString = string.toUpperCase();


Should upperString be declared using const or let?

I would use const here as I am not going to reassign the value in this case.

cjyuan · 2026-07-02T01:23:59Z

 // Use the MDN string documentation to help you find a solution
 // This might help https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toUpperCase
+
+function UPPER_SNAKE_CASE(string){


Could you look up the naming conventions in JavaScript? In particulars,

Variable and function names

Class and Types names

Named constants

Then, update the function name according to those conventions.

Many thanks. I clearly understand the naming conventions in Javascript now.

cjyuan · 2026-07-02T01:26:27Z

+  while (numString.length < 2) {
+    numString = "0" + numString;
+  }


num is either a 1-digit or 2-digit number. A conditional statement is probably enough.

Thanks for letting me know about this issue which I haven't noticed it before.

cjyuan · 2026-07-02T01:29:22Z


 function formatAs12HourClock(time) {
  const hours = Number(time.slice(0, 2));
+  const minute = pad(Number(time.slice(3,5)));


What's the difference between minute and time.slice(3, 5)?

After reading the code again, I found the type of 'minute' is expected to be in string, while time.slice(3, 5) is already a string and I decided to assign to it directly. Thanks!

cjyuan · 2026-07-05T21:55:24Z

Have you made any change based on the comments? If so, you would need to push them to GitHub so that I can review them.

cjyuan · 2026-07-06T19:49:11Z

Changes look good.

I am not sure why GitHub shows me the older version of your files yesterday.

lintsang added 4 commits June 26, 2026 22:59

finished exercises in 1-key-errors folder

a5e107e

finished exercises in the 2-mandatory-debug folder

7861f3a

finished exercises in 3-mandatory-implement folder

fecfbc2

finished exercises in 4-mandatory-interpret and 5-stretch-extend folders

e6f6333

lintsang added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 27, 2026

cjyuan reviewed Jul 2, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 2, 2026

corrected all defects

aae8c5e

lintsang added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 5, 2026

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 5, 2026

lintsang added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 6, 2026

Uh oh!

Uh oh!

Conversation

lintsang commented Jun 27, 2026

Learners, PR Template

Changelist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cjyuan commented Jul 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cjyuan commented Jul 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cjyuan Jul 2, 2026 •

edited

Loading

cjyuan commented Jul 5, 2026 •

edited

Loading