London | 26-ITP-May | Damilola Odumosu | Sprint 1 | Coursework by d-odumosu · Pull Request #1364 · CodeYourFuture/Module-Structuring-and-Testing-Data

d-odumosu · 2026-06-19T20:29:13Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I have completed the coursework requirements

cjyuan · 2026-06-23T16:32:17Z

+const dir = filePath.slice(1 , 44);
+console.log(dir)
+ const ext = filePath.slice(lastSlashIndex + 5 );
+console.log(ext)


Could you explore an approach that could work for any valid file path? For examples,
/tmp/interpret/file.json and /Users/mitch/cyf/Module-JS1/mycode.js.

i have implemented this using indexof and slice

cjyuan · 2026-06-23T16:51:47Z

+const _12HourClockTime = "8:53pm";
+const $24hourClockTime = "20:53";


Identifiers that begin with _ or $ are valid variable, function, class, and property names. However, they are usually used by convention to signal special meaning.

Could you explore names that start with alphabets instead? Feel free to ask AI for suggestion.

i'll change them to twelveHourClockTime, TwentyfourHourClockTime.

cjyuan · 2026-06-23T16:55:07Z

+// line 12 console,log()

 // b) Run the code and identify the line where the error is coming from - why is this error occurring? How can you fix this problem?
+//A syntaxError is occurring on line 5, we are missing a "," and a closing ")"


We can more precisely describe "A comma is missing between "," and "" in the function call" as:
A comma is missing between the ___________s.

What is the programming term that belongs in the blank?

Note: The original code does not have a missing closing ")".

A comma is missing between the arguments

cjyuan · 2026-06-23T17:02:57Z

-
+//runTime


runTime reads like "runtime", which has a different meaning in IT. Could you suggest a different (and more descriptive) name?

I have gone with movieRuntime, other variables could be movieLength, movieDuration

cjyuan · 2026-06-23T17:06:07Z

Regarding your PR description, could you update the checkboxes to make them look like

My changes meet the requirements of the task

instead of like

[ x ] My changes meet the requirements of the task

Relevant resource: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/about-tasklists

cjyuan · 2026-07-14T16:44:56Z

 const _12HourClockTime = "8:53pm";
 const $24hourClockTime = "20:53";

-//when starting a variable name with a number we have to precede with either of _ or $
+//when starting a variable name with a number we have to precede with either of _ or $
+//


Identifiers that begin with _ or $ are valid variable, function, class, and property names. However, they are usually used by convention to signal special meaning.

Could you explore names that start with alphabets instead? Feel free to ask AI for suggestion.

twentyFouHourClockTime and twelveHourClockTime

cjyuan · 2026-07-14T16:49:32Z

 // Create a variable to store the ext part of the variable
-const firstSlash = filePath.indexOf("/");
+const firstSlashIndex = filePath.indexOf("/");
 const period = filePath.indexOf(".");


A folder name may contain a '.'. A more robust approach would be to search for the last (instead othe first) instance of '.' in the path.

Thank you, i have implemented this

cjyuan · 2026-07-14T16:50:11Z

-const seventhSlash = filePath.indexOf("/", sixthSlash + 1);
-const eighthSlash = filePath.indexOf("/", seventhSlash + 1);

+const dirPath = filePath.slice(firstSlashIndex,lastSlashIndex + 1)


According to the diagram, the value of dir does not include a trailing '/'.

made this changes, thank you

…ling slach

cjyuan

Changes look good.

cjyuan · 2026-07-17T20:45:30Z


 // e) What do you think the variable result represents? Can you think of a better name for this variable?
-//runTime
+//movieRunTime


Could also add a prefix formatted or a suffix Str to hint the variable stores a string.

d-odumosu · 2026-07-17T21:11:00Z

Thank you so much for your time reviewing my pr.

d-odumosu added 12 commits June 17, 2026 19:49

answered question in 1-count.js

1f88977

completed 2-initials.js and tested it with logging to the console

f2ed2f5

completed 3-paths.js and tested it with logging to the console

302efee

completed 4-random.js and tested it with logging to the console

63ea100

Answered question in 0.js

7f35b33

completed task in 1.js

e6d78a0

fixed the error in 2.js

4ffd303

fixed the error in 3.js and the code now runs

78253f1

fixed the variable naming in 4.js

df2d214

answered all questions in 1-percentage-change.js

d8e5852

answered all questions in 2-time-format.js

bae8454

answered all questions in 3-to-pounds.js

20eeeea

d-odumosu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 19, 2026

cjyuan reviewed Jun 23, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 23, 2026

making changes per review

03bde13

cjyuan reviewed Jul 9, 2026

View reviewed changes

Comment thread Sprint-1/1-key-exercises/3-paths.js Outdated

revised the code per review

cc8849b

cjyuan reviewed Jul 14, 2026

View reviewed changes

d-odumosu added 4 commits July 17, 2026 20:53

explanation of the use of _ and $ sign in variables

c0aeb18

added: A comma is missing between the arguments

58ca320

renamed the variable from runtime to movieRuntime to be more descriptive

b6ac40f

added: changed the method indexof to lastindexof and removed the trai…

8499cf6

…ling slach

cjyuan reviewed Jul 17, 2026

View reviewed changes

		const _12HourClockTime = "8:53pm";
		const $24hourClockTime = "20:53";


		//runTime

Uh oh!

Uh oh!

Conversation

d-odumosu commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Jun 23, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

d-odumosu commented Jul 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

d-odumosu commented Jun 19, 2026 •

edited

Loading