London | 26-ITP-May | Yonatan Teklemariam | Sprint 3 | Todo List - #1408
Open
Yonatanteklemariam wants to merge 3 commits into
Open
London | 26-ITP-May | Yonatan Teklemariam | Sprint 3 | Todo List#1408Yonatanteklemariam wants to merge 3 commits into
Yonatanteklemariam wants to merge 3 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Yonatanteklemariam
changed the title
This comment has been minimized.
This comment has been minimized.
Yonatanteklemariam
changed the title
Yonatanteklemariam
added
the
Needs Review
LonMcGregor
reviewed
Aug 10, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work on this, I have a few suggestions for improvements
| export function addTask(todos, task, completed = false, deadline) { | ||
| const newTask = { task, completed }; | ||
|
|
||
| if (deadline !== undefined) { |
There was a problem hiding this comment.
Is there a way this if condition could be simplified? (hint: Do you need to use !== undefined if you are checking that at least "some" value is present?)
| message = `${Math.abs(diffDays)} days overdue`; | ||
| } | ||
|
|
||
| const deadlineSpan = document.createElement("span"); |
There was a problem hiding this comment.
Instead of creating a new element here, is there a better place to put this new span element that is more in line with the existing todo list code you started with?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Implemented the Todo List application by adding deadline support and based on the instructions specified
Questions