Cape Town | 26-ITP-May | Enice Mutanda | Sprint 1 |Data groups - #1395
Open
Enice-Codes wants to merge 17 commits into
Open
Cape Town | 26-ITP-May | Enice Mutanda | Sprint 1 |Data groups#1395Enice-Codes wants to merge 17 commits into
Enice-Codes wants to merge 17 commits into
Conversation
Enice-Codes
added
📅 Sprint 1
LonMcGregor
reviewed
Aug 8, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, just one comment in the median
| } else { | ||
| return numbersOnly[middleIndex]; | ||
| } | ||
| const median = numbersOnly.splice(middleIndex, 1)[0]; // |
There was a problem hiding this comment.
If this is the last thing you do in a function before returning, is it necessary to store this in a constant?
Author
There was a problem hiding this comment.
it's not necessary. If a variable is only used once, immediately before return, you can return the expression directly instead of storing it first.
| @@ -1 +1,8 @@ | |||
| function dedupe() {} | |||
| function dedupe(arr) { | |||
| return arr.filter((item ,index ) => arr.indexOf(item)=== index); | |||
LonMcGregor
added
Reviewed
Enice-Codes
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Enice-Codes
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Enice-Codes
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Enice-Codes
force-pushed
the
Data-Groups
branch
from
August 14, 2026 18:22
bad182d to
60e05a7
Compare
Enice-Codes
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Enice-Codes
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Enice-Codes
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Enice-Codes
added
the
Needs Review
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
tested all tasks locally and passed
modefied tasks
used for...loop
used if statements