London | 26-ITP-May | Mandip Sanger| Sprint 1| Data groups - #1392
Open
mandipsanger wants to merge 11 commits into
Open
London | 26-ITP-May | Mandip Sanger| Sprint 1| Data groups#1392mandipsanger wants to merge 11 commits into
mandipsanger wants to merge 11 commits into
Conversation
mandipsanger
added
📅 Sprint 1
LonMcGregor
reviewed
Aug 8, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
This all looks good, just one minor thing in dedupe
LonMcGregor
added
Reviewed
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
mandipsanger
added
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
mandipsanger
changed the title
This comment has been minimized.
This comment has been minimized.
mandipsanger
changed the title
mandipsanger
added
the
Needs Review
LonMcGregor
reviewed
Aug 11, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
The dedupe file looks fine now, I see you may have accidentally removed the invert file? was that intentional?
LonMcGregor
removed
the
Needs Review
LonMcGregor
added
the
Reviewed
Author
|
I thought I made changes in orginial file and was working in Sprint 2 so I have replaced with original. AS invert was in sprint 2 so I forget to change the branch before I start work. |
|
OK. In that case, this task is done now |
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
completed sprint 1 course work
Questions
N/A