Skip to content

West Midlands | ITP-2026-May | Alina Sofragiu | Sprint 3 | Todo list - #1391

Open
sofragiualina wants to merge 3 commits into
CodeYourFuture:mainfrom
sofragiualina:to-do-list
Open

West Midlands | ITP-2026-May | Alina Sofragiu | Sprint 3 | Todo list#1391
sofragiualina wants to merge 3 commits into
CodeYourFuture:mainfrom
sofragiualina:to-do-list

Conversation

@sofragiualina

@sofragiualina sofragiualina commented Aug 6, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Complete

@sofragiualina sofragiualina added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels Aug 6, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work,the todo list works well, there's just a minor cosmetic thing that could be improved

<button id="add-task-btn">Add</button>
</div>

<button id="delete-completed-btn">Delete completed tasks</button>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This button does not look like the other buttons, why is that?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve updated the styling so the “Delete completed tasks” button now matches the other button

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 10, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@sofragiualina sofragiualina added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 10, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 10, 2026
@github-actions

This comment has been minimized.

3 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@LonMcGregor LonMcGregor changed the title West Midlands | ITP-2026-May | Alina Sofragiu | Sprint 3 | To do list West Midlands | ITP-2026-May | Alina Sofragiu | Sprint 3 | Todo list Aug 11, 2026
@LonMcGregor LonMcGregor added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 11, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this looks much better now. Sorry about the bot giving you errors, it's resolved now

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 11, 2026
@sofragiualina

Copy link
Copy Markdown
Author

Thank you 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Groups The name of the module. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants