London | 26-ITP-May | Chinwe Chukwuma | Sprint 3 | ToDo-list-App - #1380
Open
ChinweP wants to merge 5 commits into
Open
London | 26-ITP-May | Chinwe Chukwuma | Sprint 3 | ToDo-list-App#1380ChinweP wants to merge 5 commits into
ChinweP wants to merge 5 commits into
Conversation
ChinweP
added
📅 Sprint 3
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ChinweP
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
ChinweP
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
ChinweP
force-pushed
the
module-data-groups/sprint-3/todo-list
branch
from
August 7, 2026 23:39
589818f to
45f381e
Compare
ChinweP
added
the
Needs Review
LonMcGregor
reviewed
Aug 10, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, the todo list functions well. I have one comment about the code style
| // Set up tasks to be performed once on page load | ||
| window.addEventListener("load", () => { | ||
| document.getElementById("add-task-btn").addEventListener("click", addNewTodo); | ||
| document |
There was a problem hiding this comment.
the above event listener uses a named function rather than an anonymous function, could you make these consistent?
Author
There was a problem hiding this comment.
Hi, thanks for the feedback. I've made the event listeners consistent by using named functions..
LonMcGregor
added
Reviewed
ChinweP
added
Needs Review
LonMcGregor
reviewed
Aug 11, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Great, now the code style is more consistent across the file. Task complete
LonMcGregor
added
Complete
Author
|
Thank you @LonMcGregor for reviewing my work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Todo list App coursework completed following readme instructions.