London | 26-ITP-May | Chinwe Chukwuma | Sprint 2 | Module-Data-Groups by ChinweP · Pull Request #1353 · CodeYourFuture/Module-Data-Groups

ChinweP · 2026-07-31T22:31:40Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Sprint 2 completed

cjyuan · 2026-08-06T10:35:34Z

There is another Sprint-2 folder inside the Sprint-2 folder. I am not sure which set of files are the ones to be reviewed. Could you update this PR branch accordingly?

ChinweP · 2026-08-07T16:55:37Z

@cjyuan, apologies for the inconvenience. I've removed the unnecessary Sprint-2.

cjyuan

You missed updating a few files in the implement sub-folder.

cjyuan · 2026-08-07T23:20:08Z

 // Given an object with properties
 // When passed to contains with an existing property name
 // Then it should return true
+test("returns true when object contains the property", () => {
+  const obj = { a: 1, b: 2 };
+  expect(contains(obj, "a")).toBe(true);
+});

 // Given an object with properties
 // When passed to contains with a non-existent property name
 // Then it should return false
+test("returns false when object does not contain the property", () => {
+  const obj = { a: 1, b: 2 };
+  expect(contains(obj, "c")).toBe(false);
+});


How are these two tests different from the tests on lines 19-28?

cjyuan · 2026-08-07T23:21:14Z

 // When passed to contains
 // Then it should return false or throw an error
+test("returns false for invalid parameters like an array", () => {
+  expect(contains([], "a")).toBe(false);


Arrays are objects, with their indices acting as keys. A proper test should use a non-empty array along with a valid key to ensure the function returns false specifically because the input is an array, not because the key is missing.

I have removed the duplicate tests and changed the array test to use a non-empty array with a valid key.

ChinweP · 2026-08-11T00:20:01Z

I've now updated the invalid parameter test. Thanks for pointing this out.

cjyuan · 2026-08-11T08:54:01Z

Could you also address this request?

Note: There are 8 files in the implement folder. You only updated two of them.

ChinweP · 2026-08-13T00:40:07Z

Hi, I've now updated the remaining files in the implement folder and all tests pass.

cjyuan · 2026-08-13T12:14:41Z

+    }
+
+    if (!pair.includes("=")) {
+      queryParams[pair] = "";


pair could also contain percent-encoded characters.

cjyuan · 2026-08-13T12:15:50Z

+  const counts = {};
+
+  for (const item of items) {
+    if (counts[item] === undefined) {


Does the following function call returns the value you expect?

tally(["toString", "toString"]);

Suggestion:

Look up an approach to create an empty object with no inherited properties, or

use Object.hasOwn()

…d test for 'toString' items

ChinweP · 2026-08-13T13:49:37Z

I've addressed both comments. I updated the querystring parser to decode percent-encoded keys without values and added a test for this case. I also updated tally to use Object.hasOwn() and added a test for "toString"

cjyuan · 2026-08-13T14:24:01Z

Changes look good. Well done.

ChinweP · 2026-08-13T22:27:03Z

Thank you @cjyuan for your time and for reviewing my work.

ChinweP added 11 commits July 27, 2026 16:02

Fix calculateMedian implementation so it passes all tests

7d8f402

Add dedupe implementation that passes all current tests

4649963

Implement findMax and add full test coverage for all input scenarios

bb247fd

Implement sum function and add full test coverage

816b104

Refactor includes to use a for-of loop

64a2b80

Fix address lookup by using correct object property

b057112

Fix object iteration by using Object.values() instead of for-of

c76ea74

Add correct ingredient logging by looping through recipe.ingredients

1743311

Add jest tests covering all contains() acceptance criteria

5ee5409

Fix invert function and add tests for key-value swapping

03c6296

Sprint 2 submission — clean branch

8016039

ChinweP added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels Jul 31, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 31, 2026

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

Fix revert files from Sprint 1

bfba14e

ChinweP added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 1, 2026

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 6, 2026

Fix revert files from Sprint 2

83469d1

ChinweP added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 7, 2026

cjyuan reviewed Aug 7, 2026

View reviewed changes

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 7, 2026

Improve contains tests

2b84a9b

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 10, 2026

Improve contains test

6563cf2

ChinweP added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 11, 2026

ChinweP requested a review from cjyuan August 11, 2026 00:20

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 11, 2026

ChinweP added 3 commits August 13, 2026 00:53

Implement Lookup function and tests

67b13a8

Fix querystring parsing

9c11525

Implement tally and add tests

f1a4245

ChinweP added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 13, 2026

cjyuan reviewed Aug 13, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 13, 2026

ChinweP added 2 commits August 13, 2026 14:29

Fix querystring parsing for encoded keys

8214876

Refactor tally function to use Object.hasOwn for item counting and ad…

65aec0f

…d test for 'toString' items

ChinweP added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 13, 2026

ChinweP requested a review from cjyuan August 13, 2026 13:50

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 13, 2026

ChinweP mentioned this pull request Aug 14, 2026

London-ITP-May-26 | Module-Data-Groups | Chinwe Chukwuma ChinweP/My-Coursework-Planner#57

Open

Uh oh!

Uh oh!

Conversation

ChinweP commented Jul 31, 2026

Learners, PR Template

Changelist

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

cjyuan commented Aug 6, 2026

Uh oh!

ChinweP commented Aug 7, 2026

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

ChinweP Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

ChinweP commented Aug 11, 2026

Uh oh!

cjyuan commented Aug 11, 2026

Uh oh!

ChinweP commented Aug 13, 2026

Uh oh!

cjyuan Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

ChinweP commented Aug 13, 2026

Uh oh!

cjyuan commented Aug 13, 2026

Uh oh!

ChinweP commented Aug 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants