fix(test): remove obsolete CDN-pin tests that conflict with landing redesign - #130
Merged
Merged
Conversation
…edesign PR #128 merged the landing redesign (which replaced CDN-pinned SPA with local ./app.js) alongside the pin-tripwire tests (which assert CDN URLs exist). Git merged cleanly but the result is a semantic conflict — the three CDN-pin tests always fail because the landing page no longer uses cdn.jsdelivr.net URLs. The existing test at line 156 ("landing runtime is source-owned and dependency-free") already validates the new architecture. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016zx8GBFwDjPucFz3QWy97Y
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016zx8GBFwDjPucFz3QWy97Y
Apply biome auto-fixes to clear errors that were masked by the test failures on master: template literal preference in dash.html, optional chaining in gateway_model_map.js and init.js, and formatting in merge_impact files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016zx8GBFwDjPucFz3QWy97Y
CodeWithJuber
marked this pull request as ready for review
August 14, 2026 07:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
PR #128 merged the landing redesign (which replaced the CDN-pinned SPA with a local
./app.jsruntime) alongside the pin-tripwire tests (which assert CDN URLs exist). Git merged without conflict because the changes were in non-overlapping hunks, but the result is a semantic merge conflict — three CDN-pin tests always fail because the landing page no longer usescdn.jsdelivr.netURLs.This removes the three obsolete tests from
test/pages.test.js:pinned landing chunks form a complete closure(expected CDN entry chunks)jsDelivr pin is never older than the newest landing/assets commit(expected a pinned commit SHA in a CDN URL)deployed site serves the same chunks the repo pins(expected CDN URLs in deployed site)The existing test
landing runtime is source-owned and dependency-free(line 156) already validates the new architecture by asserting no CDN URLs exist and that only./app.jsis loaded locally.This also unblocks PR #129 which was failing CI due to this pre-existing issue on
master.Checklist
npm testpasses (Node 18/20/22)npm run checkpasses (Biome lint + format)feat:/fix:/docs:…)CHANGELOG.mdupdated under## [Unreleased]forge substrate,forge impact, router/gate, or MCP substrate toolsRisk & rollback
Extra checks (tick if applicable)
npm run typecheckpassesGenerated by Claude Code