Update Decap so PKCE works - #56
Conversation
|
Thanks @paulnicholsen27, One thing you can do in the meantime is to get rid of these changes in the package-lock.json because they don't seem related to your issue. |
|
@ItsEthanH |
I figured--maybe mention this in the docs somewhere? Would save a lot of head-banging time trying to get the Google login to work, unless I'm missing something |
Only incidental npm metadata, no dependency changes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
So I agree with a lot of what @BuckyBuck135 says about the syntax. Using the h() syntax is incredibly unfriendly, and we're already pushing the definition of "Intermediate" when dealing with this part of the kit. Therefore any issue should be approached with the best DX in mind, while also keeping everything as up to date as possible. In order to respect this, my changes propose:
I wasn't aware of @jsx h when this was originally implemented, but thanks for some LLM-assisted searching, this seems to be the best fit. We don't need to render two versions of React and can instead just compile directly to the same thing the latest versions of Decap use. @paulnicholsen27 (and others!), any complaints against me merging this in it's current state? |
|
@ItsEthanH After going through the breaking changes, I only found a small one: date doesn't default to anything anymore, so I reintroduced it with 5fd1d20 |
@paulnicholsen27 |
|
If you're updating Decap, I don't think you need to change the README. I just thought mentioning that PKCE wouldn't work without the updated version would be helpful, but this is better! |
|
LGTM |
In order to get PKCE login to work, I needed to update the Decap version. This caused a React conflict, so now Decap uses its own React.