Skip to content

ParsingHtmlWithAngleSharp: retarget net10.0, bump AngleSharp 1.6.0, drop unneeded WithJs() calls #2082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CodeMazeBlog merged 7 commits into from
Aug 11, 2026
Merged

ParsingHtmlWithAngleSharp: retarget net10.0, bump AngleSharp 1.6.0, drop unneeded WithJs() calls #2082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0b8c41e
CM-46: Delegates in C# Inital Commit
CodeMazeBlog Nov 7, 2021
ae94207
Cleaning
CodeMazeBlog Nov 8, 2021
78a0066
Merge branch 'CodeMazeBlog:main' into main
vladimir-pecanac-main Aug 3, 2026
abab02c
Merge branch 'CodeMazeBlog:main' into main
vladimir-pecanac-main Aug 3, 2026
3b80c14
Merge remote-tracking branch 'upstream/main' into main
vladimir-pecanac-main Aug 10, 2026
89895a5
Merge upstream/main into fork main
vladimir-pecanac-main Aug 11, 2026
6932da6
ParsingHtmlWithAngleSharp: retarget net10.0, bump AngleSharp 1.6.0, d…
vladimir-pecanac-main Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ries/ParsingHtmlWithAngleSharp/ParsingHtmlWithAngleSharp/ParsingHtmlWithAngleSharp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="AngleSharp" Version="1.0.7" />
<PackageReference Include="AngleSharp" Version="1.6.0" />
<PackageReference Include="AngleSharp.Io" Version="1.0.0" />
<PackageReference Include="AngleSharp.Js" Version="0.15.0" />
</ItemGroup>
Expand Down
14 changes: 3 additions & 11 deletions ...et-client-libraries/ParsingHtmlWithAngleSharp/Tests/ParsingHtmlWithAngleSharpUnitTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,7 @@
{
var booksCatalogUrl = "https://books.toscrape.com/";

var config = Configuration.Default
.WithDefaultLoader()
.WithJs();
var config = Configuration.Default.WithDefaultLoader();
var context = BrowsingContext.New(config);

var document = await context.OpenAsync(new Url(booksCatalogUrl));
Expand All @@ -200,19 +198,13 @@
[Fact]
public async Task WhenParsingHtmlFromString_ThenDocumentIsCreatedAndDomManipulationChangesDomAsExpected()
{
var config = Configuration.Default
.WithDefaultLoader()
.WithJs();

var context = BrowsingContext.New(config);
var context = BrowsingContext.New(Configuration.Default);
var document = await context.OpenAsync(req => req.Content(Html));

var paragraphElement = document.CreateElement("p");

paragraphElement = document.CreateElement<IHtmlParagraphElement>();
var paragraphElement = document.CreateElement<IHtmlParagraphElement>();
paragraphElement.TextContent = "This is a new paragraph.";

document.Body.AppendChild(paragraphElement);

Check warning on line 207 in dotnet-client-libraries/ParsingHtmlWithAngleSharp/Tests/ParsingHtmlWithAngleSharpUnitTests.cs

View workflow job for this annotation

GitHub Actions / Build & test (dotnet-client-libraries/ParsingHtmlWithAngleSharp) 

Dereference of a possibly null reference.

Check warning on line 207 in dotnet-client-libraries/ParsingHtmlWithAngleSharp/Tests/ParsingHtmlWithAngleSharpUnitTests.cs

View workflow job for this annotation

GitHub Actions / Build & test (dotnet-client-libraries/ParsingHtmlWithAngleSharp) 

Dereference of a possibly null reference.

Assert.IsAssignableFrom<IHtmlParagraphElement>(document.Body.Children[^1]);

Expand Down
2 changes: 1 addition & 1 deletion dotnet-client-libraries/ParsingHtmlWithAngleSharp/Tests/Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>

Expand Down
Loading