Repository navigation
ParameterInfoImpl: build the fully qualified name once, intern and keep it - #163
Merged
Merged
Conversation
…is committed, interned and shared Signed-off-by: Tom Tourwe <Tom.Tourwe@codelaser.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes, and why
ParameterInfoImpl.fullyQualifiedName()built a new string on every call: the method's fully qualified name, the parameter's index and its name. On a method with a long parameter list, that string is a few kilobytes, and the analysis keeps it per statement that refers to the parameter. On a large codebase after a refactoring that added long parameter lists, one parse held 14 GB ofbyte[]in these strings and ran out of memory. With this change, the parse of the same code holds 1.2 GB ofbyte[].The name is now built once and kept, in a field marked
@IgnoreModifications, the same way as other memoised values in the info classes. It is only kept once the method has been inspected (methodInfo.hasBeenInspected()), because before that the method's name, and so the parameter's, can still change. The kept string is interned, so equal parameter names share one string.