Repository navigation
SourceCodeScan: scan the code of an enum constant - #162
Merged
Merged
Conversation
An enum constant's arguments -- an anonymous class passed to the constructor, a call -- and its own class body were never scanned: only its comments were. A call there had no END_OF_ARGUMENT_LIST, and a consumer adding an argument fell back to the start of the call: codelaser bean.migrate turned `Util.label()` into `x1til.label()` in an enum of closed-core whose constants each get an anonymous handler. Test: TestSourceCodeScan.test8_enumConstants. Signed-off-by: Tom Tourwe <Tom.Tourwe@codelaser.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devel.What this changes, and why
SourceCodeScanrecorded only the comments of an enum constant. It never scanned the constant's code: its arguments (for example an anonymous class passed to the enum's constructor,ONE(new Handler() { ... })) and a constant's own class body (TWO { ... }). So a call written there had noEND_OF_ARGUMENT_LIST. A consumer that adds an argument to such a call has no position for the closing parenthesis and falls back to the start of the call: in a closed-core enum whose constants each get an anonymous handler, adding the argumentx1toUtil.label()producedx1til.label().scanEnumConstantnow also scans the constant's code, the same way a field's initializer is scanned (scanCodeBlock).