Repository navigation
feat(kernel): port fixes, takesOver, locales and a settings cache - #671
Merged
Merged
Conversation
The kernel changes from the November review (#665). - Verdicts include misleading. A verdict update carries a report link and a withdrawn flag. - LLMProvider.generate returns the output and the tokens used. - StructuredImporter only reads files: inspect and rows (D49). - takesOver lists core fields a plugin writes while enabled. They are read-only in the admin to everyone but a super-admin, and a super-admin's change is logged. - Plugin settings are read once and reused. A save clears them in that process, and other processes read again within 30 seconds. - PT_LOCALES chooses from the registered locales, and start-up stops on any other code (D45).
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kernel changes from the November review, in the order the issue lists them.
Closes #665
What it changes
misleading, as in section 7.5.withdrawnflag, so an adapter can tell a withdrawn report from a claim not yet verified.LLMProvider.generatereturns the structured output and the tokens used.StructuredImporteronly reads files:inspectandrows. It no longer creates records (D49). The core does the mapping, preview and commit in V1-07: Areas, offices and spreadsheet import #645.takesOvermanifest entry lists fields a plugin writes while enabled, as dotted paths such asverification.verdict(section 4.5).dependsOn, and on two enabled plugins taking over one field.PT_LOCALESand stops start-up on a code that is not registered (D45). The registered list is inapps/cms/src/locales.ts: English, French, Portuguese, Arabic and Swahili. English is always on.Decisions made while building
rowsreturns an async iterable with each row's number, so a large file is not held in memory and errors can name the row.takesOverpath steps through groups and named tabs. Fields inside arrays and blocks cannot be taken over.PT_LOCALESis checked and shown in the start-up line, and nothing else reads it.Environment and config
PT_LOCALES. Defaults toen. Documented in.env.exampleand passed through Compose.Migrations
None. The schema is unchanged.
How to test
pnpm services pnpm testChecked locally: lint, type check, the migration check, 100 unit, 3 integration and 5 browser tests. The browser tests ran against the dev server.