Skip to content

Improve Application Service Types & Add Review Entity Relation #181

Description

@madisonweiss

Description:

  1. In applications.service.ts, several functions currently use the any type. This is dangerous - replace any with the correct, strongly typed definitions to improve type safety. Also, in submitApp(), follow the existing TODO to make the user dynamic.
  2. Update the reviews entity: it currently has a reviewerId field. Create a proper one-to-many relationship between reviews and the user entity using TypeORM. Verify the new relationship by adding and deleting reviews through PgAdmin to ensure data integrity.

Acceptance Criteria:

  • No usage of any type remains in applications.service.ts
  • submitApp() dynamically handles user as intended
  • One-to-many relationship between reviews and user entity is correctly implemented
  • Adding and deleting reviews via PgAdmin reflects correctly in the database and respects entity relationships

Resources:

T-Shirt Size: M

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions