Repository navigation
Require ShellKit by version (0.1.x) so SwiftScript can be tagged - #21
Merged
Merged
Conversation
SwiftPM refuses a version requirement on a package whose own dependencies are branch-pinned, so as long as SwiftScript required ShellKit by `branch: "main"` nobody could depend on SwiftScript by version — and neither could SwiftBash, which sits above it. ShellKit 0.1.0 is now tagged. The requirement becomes `.upToNextMinor(from: "0.1.0")`: ShellKit is 0.x and a minor bump may change API, so the family moves minors together rather than floating across them. Package.resolved moves from the `main` pin (ce21474) to the 0.1.0 tag (40c1b41); the two intervening ShellKit changes (lazy process stdin, UNC root normalisation) don't touch anything SwiftScript uses. Part of the bottom-up version tagging across the ShellKit family (Cocoanetics/SwiftBash#89). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SwiftPM refuses a version requirement on a package whose own dependencies are branch-pinned. While SwiftScript required ShellKit by
branch: "main", nobody could depend on SwiftScript by version, and neither could SwiftBash above it (Cocoanetics/SwiftBash#89).What
Package.swift: ShellKitbranch: "main"→.upToNextMinor(from: "0.1.0"). ShellKit is 0.x and a minor bump may change API, so dependents in the family pin the minor and move together.Package.resolved: ShellKit moves from themainpin (ce21474) to the 0.1.0 tag (40c1b41).Verification
Local
swift test: 580 tests in 63 suites, 579 pass. The one failure isprobeMatchesStockSwift("34_auto_harvest_smoke"), which is unrelated to this change: the golden saysCharacterSet.isDisjoint(with:)on a set and its inverse isfalse, but stock Swift 6.4 on current macOS printstrue, and so does the interpreter. The golden is stale for the current Foundation; tracked separately.Follow-up
Once merged, tag
0.1.0so SwiftBash can requireSwiftScript .upToNextMinor(from: "0.1.0").🤖 Generated with Claude Code