[pull] main from Alishahryar1:main - #258
Merged
Merged
Conversation
## Why Opening Integrations reparses native configuration files and queues every card behind one configuration lock. A large VS Code model file makes unrelated cards wait. Local provider reachability results also wait for the slowest check because they share one response. ## How Decode ordinary JSON with the standard parser while retaining JSON5 support and duplicate/nonfinite validation. Give each integration concurrent reader access and exclusive writer access, preserving configuration publication ordering, generation checks, multi-file consistency, and worker ownership through cancellation. Return local reachability results per provider and render each result independently. Track integration requests by their configuration so replies from an earlier load cannot overwrite newer results or clear their loading state. <!-- greptile_comment --> <!-- greptile_summary --> <h2><a href="https://app.greptile.com/api/retrigger?id=71899390"><picture><source media="(prefers-color-scheme: dark)" srcset="https://greptile-static-assets.s3.amazonaws.com/badges/RetriggerDark.svg?v=2"><source media="(prefers-color-scheme: light)" srcset="https://greptile-static-assets.s3.amazonaws.com/badges/Retrigger.svg?v=2"><img alt="Retrigger" src="https://greptile-static-assets.s3.amazonaws.com/badges/Retrigger.svg?v=2" align="right"></picture></a>Confidence Score: 5/5</h2> <!-- greptile-risk --> No outstanding finding or merge blocker was identified. <details open><summary>Summary</summary> Admin status checks run independently, so a slow integration or local provider check does not delay other results. The latest change synchronizes the browser test’s local-provider assertions. </details> <!-- greptile_confidence_score:5 --> <sub>Reviews (2) · Last reviewed commit: ["test: Synchronize local provider status ..."](https://github.com/alishahryar1/free-claude-code/commit/b89b44b2a3f67b8637368b4ca0fbe08f03b43116)</sub> <!-- /greptile_comment -->
![https://greptile-static-assets.s3.amazonaws.com/badges/RetriggerDark.svg?v=2"><source](https://greptile-static-assets.s3.amazonaws.com/badges/RetriggerDark.svg?v=2"><source){kind=link}
![https://greptile-static-assets.s3.amazonaws.com/badges/Retrigger.svg?v=2"><img](https://greptile-static-assets.s3.amazonaws.com/badges/Retrigger.svg?v=2"><img){kind=link}
## Why ChatGPT model discovery rejects Python development versions such as `6.5.9.dev3+gb89b44b2a` with HTTP 400. This leaves a connected account unable to load its models when FCC runs from a development checkout. ## How Convert the model-list `client_version` parameter to SemVer using the existing `packaging.Version` parser. Preserve the development counter and local build metadata, producing values such as `6.5.9-dev.3+gb89b44b2a`, and give source-only installs a valid development version. <!-- greptile_comment --> <!-- greptile_summary --> <h2><a href="https://app.greptile.com/api/retrigger?id=71923240"><picture><source media="(prefers-color-scheme: dark)" srcset="https://greptile-static-assets.s3.amazonaws.com/badges/RetriggerDark.svg?v=2"><source media="(prefers-color-scheme: light)" srcset="https://greptile-static-assets.s3.amazonaws.com/badges/Retrigger.svg?v=2"><img alt="Retrigger" src="https://greptile-static-assets.s3.amazonaws.com/badges/Retrigger.svg?v=2" align="right"></picture></a>Confidence Score: 4/5</h2> <!-- greptile-risk --> The inaccurate version parameter is a non-blocking concern; the observed model request still succeeded with the mocked response. <h2><a href="https://app.greptile.com/api/ide/codex?prompt=IMPORTANT%3A%20Work%20in%20the%20repository%20%22alishahryar1%2Ffree-claude-code%22%20on%20the%20existing%20branch%20%22ali%2Fopenai-client-version-format%22.%20Checkout%20that%20branch%20%E2%80%94%20do%20NOT%20create%20a%20new%20branch%20or%20open%20a%20new%20PR.%20Push%20your%20changes%20to%20%22ali%2Fopenai-client-version-format%22.%0A%0A%23%23%23%20Issue%201%0Asrc%2Ffree_claude_code%2Fproviders%2Fopenai_codex%2Fprovider.py%3A210-212%0AFor%20a%20%606.5.9rc1.dev3%60%20build%2C%20model%20discovery%20sends%20%60client_version%3D6.5.9-dev.3%60.%20The%20parameter%20no%20longer%20identifies%20the%20release%20candidate%2C%20making%20the%20catalog%20request's%20version%20information%20misleading.%20This%20is%20a%20non-blocking%20reporting%20concern%3B%20preserve%20the%20release-candidate%20identifier%20in%20the%20converted%20value.%0A%0ANote%3A%20If%20this%20suggestion%20doesn't%20match%20your%20team's%20coding%20style%2C%20reply%20to%20this%20and%20let%20me%20know.%20I'll%20remember%20it%20for%20next%20time!%0A%0A---%0A%0AFor%20each%20issue%20above%2C%20determine%20whether%20it%20is%20valid%20and%20should%20be%20fixed.%20If%20so%2C%20fix%20it%20directly.&repo=alishahryar1%2Ffree-claude-code&pr=1956&platform=github"><picture><source media="(prefers-color-scheme: dark)" srcset="https://greptile-static-assets.s3.amazonaws.com/badges/FixAllInCodexDark.svg?v=7"><source media="(prefers-color-scheme: light)" srcset="https://greptile-static-assets.s3.amazonaws.com/badges/FixAllInCodex.svg?v=7"><img alt="Fix All in Codex" src="https://greptile-static-assets.s3.amazonaws.com/badges/FixAllInCodex.svg?v=7" align="right"></picture></a>Findings</h2> 1. <img alt="P2" src="https://greptile-static-assets.s3.amazonaws.com/badges/p2.svg?v=9" align="top"> **Release candidate is omitted** <a href="https://github.com/Alishahryar1/free-claude-code/pull/1956#discussion_r4142083284">▶</a> <details open><summary>Summary</summary> The PR converts package versions for the Codex model-list request and adds version-formatting tests. For release-candidate builds, the conversion omits the release-candidate identifier, so the request reports a different version. </details> <!-- greptile_confidence_score:4 --> <sub>Reviews (1) · Last reviewed commit: ["patch: Format development versions for C..."](https://github.com/alishahryar1/free-claude-code/commit/b4a6b0886b7585ab3c1f4b5cb369ca9c3c7721c4)</sub> <!-- /greptile_comment -->
![https://greptile-static-assets.s3.amazonaws.com/badges/FixAllInCodexDark.svg?v=7"><source](https://greptile-static-assets.s3.amazonaws.com/badges/FixAllInCodexDark.svg?v=7"><source){kind=link}
![https://greptile-static-assets.s3.amazonaws.com/badges/FixAllInCodex.svg?v=7"><img](https://greptile-static-assets.s3.amazonaws.com/badges/FixAllInCodex.svg?v=7"><img){kind=link}
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )