Repository navigation
[pull] main from Alishahryar1:main - #243
Merged
Merged
Conversation
## Why CI previously exercised pytest and Playwright only on Linux, leaving Windows and macOS failures undiscovered. Its shared job exposed irrelevant browser steps in other checks, and post-merge cache warming covered only Linux. The new runners exposed protected-file metadata copying in macOS fixtures, browser tests racing startup or loading real providers, and packaged assets depending on the host MIME registry. Windows pytest also exceeded the inherited 15-minute limit before printing two Pi failures. ## How Give pytest and headless Chromium Playwright separate three-OS matrices. Keep the ban, Ruff, and Ty checks on Linux. Share managed Python and dependency-cache setup through one composite action with portable paths, dependency fingerprints, and unique browser-artifact names. Warm matching caches on all three operating systems after merges, with PR jobs restoring caches only. Copy executable permissions without protected macOS metadata, keep browser provider construction inside explicit test doubles, and await code-service startup before simulating unavailability. Serve packaged JS, CSS, SVG, and PNG assets with explicit content types. Add structural coverage for all six required test checks, including deletion cases, and bump FCC to 6.2.63. Give Windows pytest a 45-minute job budget and report slow test phases. Prepare Node's ES-module loader, TypeScript stripping, and fetch primitives through shared CI setup for all three pytest jobs. Windows tracing identified cold executable paging as the Pi timeout cause. The original Pi timeout checks now pass, so remove the temporary observer, profiling wrapper, and early-exit option. Use Playwright system dependency installation only on Linux, avoiding the slow Media Foundation installation on Windows. Give each pagination setup event its existing timeout instead of placing all 55 sequential events under one deadline. Wait for native submission before checking the competing-tabs input count. Run component-specific PowerShell installer cases through the real source functions, loaded using PowerShell's parser. Preserve parameterized compatibility and failure assertions while avoiding unrelated installations. Keep full-script coverage for fresh installation, prompts, shared PATH behavior, process guards, representative phase failures, and uninstall ownership. Continue exercising both PowerShell 7 and 5.1. Wait for integration request interception before inspecting or completing held browser requests. Keep temporary CI diagnostics enabled while investigating the macOS folder-picker hang and hosted Windows installer cost. Report stalled Python threads and picker tasks directly in live logs, and timestamp the existing fresh-install scenarios in both PowerShell versions. <!-- greptile_comment --> <!-- greptile_summary --> <h2><a href="https://app.greptile.com/api/retrigger?id=69107641"><picture><source media="(prefers-color-scheme: dark)" srcset="https://greptile-static-assets.s3.amazonaws.com/badges/RetriggerDark.svg?v=2"><source media="(prefers-color-scheme: light)" srcset="https://greptile-static-assets.s3.amazonaws.com/badges/Retrigger.svg?v=2"><img alt="Retrigger" src="https://greptile-static-assets.s3.amazonaws.com/badges/Retrigger.svg?v=2" align="right"></picture></a>Confidence Score: 4/5</h2> <!-- greptile-risk --> The outstanding Windows pytest time-limit concern should be addressed before merging. <details open><summary>Summary</summary> The PR runs pytest and Playwright across Linux, Windows, and macOS and improves cross-platform test setup. The Windows pytest job still has a 15-minute limit; if the full job exceeds it, CI will cancel before reporting all test results. </details> <!-- greptile_confidence_score:4 --> <sub>Reviews (13) · Last reviewed commit: ["Wait for intercepted requests and comple..."](https://github.com/alishahryar1/free-claude-code/commit/149cdd19d474f30eb29291f5b8f35bab3cf077bd)</sub> <!-- /greptile_comment -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
![https://greptile-static-assets.s3.amazonaws.com/badges/RetriggerDark.svg?v=2"><source](https://greptile-static-assets.s3.amazonaws.com/badges/RetriggerDark.svg?v=2"><source){kind=link}
![https://greptile-static-assets.s3.amazonaws.com/badges/Retrigger.svg?v=2"><img](https://greptile-static-assets.s3.amazonaws.com/badges/Retrigger.svg?v=2"><img){kind=link}
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )