Repository navigation
[pull] main from Alishahryar1:main - #241
Merged
Merged
Conversation
## Why OpenAI can reject `temperature` or `top_p` for a model's current reasoning mode, preventing otherwise valid FCC requests from completing. FCC needs to handle those explicit incompatibility errors without maintaining model-name rules or discarding settings that OpenAI accepts. ## How Send the original sampling settings, then use an OpenAI API-specific correction callback in the shared Responses transport to remove only the field explicitly rejected upstream. Recognize structured `unsupported_parameter` errors and the narrow default-only `unsupported_value` form. Both Messages and native Responses use the existing recovery path, including reasoning/history corrections, stream commitment safeguards, and the shared five-attempt limit. Corrections apply only to the current request: there is no model table or capability cache. Each subsequent request starts with its original settings, so incompatible requests can incur extra round trips. Ambiguous and unrelated validation errors keep their normal failure behavior. Bump the package version to 6.2.60. <!-- greptile_comment --> <!-- greptile_summary --> <h2><a href="https://app.greptile.com/api/retrigger?id=68632430"><picture><source media="(prefers-color-scheme: dark)" srcset="https://greptile-static-assets.s3.amazonaws.com/badges/RetriggerDark.svg?v=2"><source media="(prefers-color-scheme: light)" srcset="https://greptile-static-assets.s3.amazonaws.com/badges/Retrigger.svg?v=2"><img alt="Retrigger" src="https://greptile-static-assets.s3.amazonaws.com/badges/Retrigger.svg?v=2" align="right"></picture></a>Confidence Score: 5/5</h2> No outstanding findings block merging. <details open><summary>Summary</summary> The OpenAI API provider now preserves requested sampling settings until OpenAI explicitly rejects one, then retries without the rejected setting. Both previously reported issues are fixed. </details> <!-- greptile_confidence_score:5 --> <sub>Reviews (3) · Last reviewed commit: ["Correct OpenAI sampling only after expli..."](https://github.com/alishahryar1/free-claude-code/commit/c397b03337473e4625dce5e40988a456985e5473)</sub> <!-- /greptile_comment -->
![https://greptile-static-assets.s3.amazonaws.com/badges/RetriggerDark.svg?v=2"><source](https://greptile-static-assets.s3.amazonaws.com/badges/RetriggerDark.svg?v=2"><source){kind=link}
![https://greptile-static-assets.s3.amazonaws.com/badges/Retrigger.svg?v=2"><img](https://greptile-static-assets.s3.amazonaws.com/badges/Retrigger.svg?v=2"><img){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )