Skip to content

[pull] main from Alishahryar1:main - #235

Merged
pull[bot] merged 1 commit into
Co-Contribute-OpenSource:mainfrom
Alishahryar1:main
Sep 21, 2026
Merged

pull[bot] merged 1 commit into
Co-Contribute-OpenSource:mainfrom
Alishahryar1:main

Conversation

@pull

@pull pull Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

## Why

The JetBrains ACP card currently opens a no-op modal. Users need Connect
and Disconnect to configure Claude Code through FCC from that card.

## How

- Connect adds a dedicated **Claude Code (FCC)** agent to
`~/.jetbrains/acp.json`, using JetBrains' installed Claude ACP adapter
and a compatible existing Node runtime. The modal shows the affected
file and setup instructions.
- Recognize the FCC entry by its ownership marker. Refresh its token,
server address, shared Claude settings, and installed adapter paths when
FCC starts. Preserve other agents and settings; reject same-name entries
without the marker.
- Disconnect removes the dedicated entry, including customizations
inside it. Keep Disconnect available when adapter discovery or startup
refresh fails.
- Use the existing serialized configuration operations and atomic file
writer. Support JSON5 input with duplicate-key rejection; writes use
ordinary JSON and may discard comments and formatting.
- Support standard local JetBrains locations on Windows, macOS, and
Linux. Users install and start Claude Agent in JetBrains first, and
restart FCC after agent updates to refresh versioned paths.
- Update the README setup steps and bump the patch version to
**6.2.52**.


<!-- greptile_comment -->

<!-- greptile_summary -->

<h2><a
href="https://app.greptile.com/api/retrigger?id=66764839"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://greptile-static-assets.s3.amazonaws.com/badges/RetriggerDark.svg?v=2"><source
media="(prefers-color-scheme: light)"
srcset="https://greptile-static-assets.s3.amazonaws.com/badges/Retrigger.svg?v=2"><img
alt="Retrigger"
src="https://greptile-static-assets.s3.amazonaws.com/badges/Retrigger.svg?v=2"
align="right"></picture></a>Confidence Score: 4/5</h2>

Not safe to merge until the Linux-breaking Windows simulation in the
JetBrains ACP harness is corrected.

<h2><a
href="https://app.greptile.com/api/ide/codex?prompt=IMPORTANT%3A%20Work%20in%20the%20repository%20%22alishahryar1%2Ffree-claude-code%22%20on%20the%20existing%20branch%20%22ali%2Fjetbrains-acp-integration%22.%20Checkout%20that%20branch%20%E2%80%94%20do%20NOT%20create%20a%20new%20branch%20or%20open%20a%20new%20PR.%20Push%20your%20changes%20to%20%22ali%2Fjetbrains-acp-integration%22.%0A%0A%23%23%23%20Issue%201%0Atests%2Fharnesses%2Ftest_jetbrains_acp_integration.py%3A213%0AThis%20test%20changes%20only%20the%20ACP%20module's%20platform%20value%20to%20%60win32%60%20and%20then%20calls%20%60configure%28%29%60.%20On%20Linux%2C%20that%20path%20reaches%20the%20Windows-only%20%60subprocess.CREATE_NO_WINDOW%60%20attribute%2C%20which%20is%20absent%20on%20the%20host%20module%2C%20so%20it%20raises%20%60AttributeError%60%20before%20validating%20the%20Windows%20layout.%20Mock%20the%20Windows%20subprocess%20flag%20as%20part%20of%20the%20simulation%2C%20or%20separate%20the%20path-layout%20assertion%20from%20launch%20behavior.%0A%0A---%0A%0AFor%20each%20issue%20above%2C%20determine%20whether%20it%20is%20valid%20and%20should%20be%20fixed.%20If%20so%2C%20fix%20it%20directly.&repo=alishahryar1%2Ffree-claude-code&pr=1848&platform=github"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://greptile-static-assets.s3.amazonaws.com/badges/FixAllInCodexDark.svg?v=7"><source
media="(prefers-color-scheme: light)"
srcset="https://greptile-static-assets.s3.amazonaws.com/badges/FixAllInCodex.svg?v=7"><img
alt="Fix All in Codex"
src="https://greptile-static-assets.s3.amazonaws.com/badges/FixAllInCodex.svg?v=7"
align="right"></picture></a>Findings</h2>

1. <img alt="P1"
src="https://greptile-static-assets.s3.amazonaws.com/badges/p1.svg?v=9"
align="top">&nbsp;**Windows simulation breaks Linux CI** <a
href="https://github.com/Alishahryar1/free-claude-code/pull/1848#discussion_r4058822613">▶</a>

<details open><summary>Summary</summary>



The JetBrains ACP integration adds runtime configuration, administrative
controls, and test coverage. The simulated Windows harness path fails on
Linux before it can validate the Windows configuration layout, so this
must be fixed before merging.
</details>

<sub>Reviews (1) · Last reviewed commit: ["Connect Claude Code through
JetBrains
AC..."](https://github.com/alishahryar1/free-claude-code/commit/5c44d43c60ee5ae74a2ab9e3db75f94c9eb89c0a)</sub>

<!-- /greptile_comment -->
@pull pull Bot locked and limited conversation to collaborators Sep 21, 2026
@pull pull Bot added the ⤵️ pull label Sep 21, 2026
@pull
pull Bot merged commit 56ded24 into Co-Contribute-OpenSource:main Sep 21, 2026
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant