Skip to content

fix(helm): drop the CELERY_ACCEPT_CONTENT default - #32

Merged
lewisjared merged 3 commits into
mainfrom
fix/celery-accept-content-default
Jul 28, 2026
Merged

fix(helm): drop the CELERY_ACCEPT_CONTENT default#32
lewisjared merged 3 commits into
mainfrom
fix/celery-accept-content-default

Conversation

@lewisjared

Copy link
Copy Markdown
Contributor

Removes the CELERY_ACCEPT_CONTENT default from defaults.env.

The chart set it to the JSON array string ["json", "pickle"]. The v0.16.2 image ignored it, because accept_content was hardcoded in celeryconf/base.py. Climate-REF/climate-ref#850 reads it with env.list(), which splits on commas, so the same value yields ['["json"', '"pickle"]'] and every worker dies at startup with SerializerNotInstalled: No encoder/decoder installed for ["json".

  • Drops the default, so the image owns it. The new default is json,ref-json.
  • Adds commented examples for CELERY_TASK_COMPRESSION, CELERY_RESULT_COMPRESSION and the comma separated CELERY_ACCEPT_CONTENT, matching the upstream chart.
  • Documents the pickle drain path in helm/README.md: set json,ref-json,pickle over a rolling upgrade, then revert.
  • Notes that Flower cannot decode ref-json bodies, so its broker queue view will not show task args. Task rows still appear, because worker events are plain JSON.

Safe with either image, so it does not need to land with the version bump. The v0.16.2 image ignores the variable, and the post-#850 image falls back to its own default.

The compose stack still pins v0.16.2, so docker/docker-compose.yaml is untouched. Flower's CELERY_ACCEPT_CONTENT there needs updating in the bump PR.

The value was a JSON array string, which the worker now parses as a comma
separated list. Let the image own the default instead.
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@lewisjared, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b7057f46-2e80-4fe1-920a-45acd8da19d2

📥 Commits

Reviewing files that changed from the base of the PR and between 29b1e04 and df8bcce.

📒 Files selected for processing (3)
  • changelog/32.fix.md
  • helm/README.md
  • helm/values.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/celery-accept-content-default

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lewisjared
lewisjared merged commit 1c29b70 into main Jul 28, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant