Repository navigation
Declare Terminal::read_unicode_character on Windows too - #54
Open
alexey-milovidov wants to merge 1 commit into
Open
alexey-milovidov wants to merge 1 commit into
alexey-milovidov wants to merge 1 commit into
Conversation
`bracketed_paste` calls it as a member of `Terminal` since the merge of #49, but it was declared and defined only outside `_WIN32`, so `replxx_impl.cxx` no longer compiled for Windows. On Windows it reads one code point from the console with `ReadConsoleW`, combining a surrogate pair. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alexey-milovidov
added a commit
to ClickHouse/ClickHouse
that referenced
this pull request
Oct 20, 2026
The updated `replxx` calls `Terminal::read_unicode_character` as a member in `bracketed_paste`, which was declared only outside `_WIN32`. Point the submodule at ClickHouse/replxx#54, which declares and defines it on Windows too, and drop the free function from `replxx-windows-tty.cxx` that it replaces. `SocketImpl::acceptConnection` now marks accepted sockets close-on-exec with `fcntl` where `accept4` is missing; on Windows a socket is a handle, so clear its `HANDLE_FLAG_INHERIT` instead. CI report: https://s3.amazonaws.com/clickhouse-test-reports/PRs/112824/6d55c156e6e63e47a0b7cc1cb1a4d06ca54d9c9e/pr/build_amd_windows/build_clickhouse/build_clickhouse.log Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🕵
bracketed_pastecallsTerminal::read_unicode_characteras a member since #49, but the member was declared and defined only outside_WIN32, soreplxx_impl.cxxno longer compiled for Windows. On Windows it now reads one code point from the console withReadConsoleW, combining a surrogate pair.Needed by the Windows port in ClickHouse: ClickHouse/ClickHouse#112824
🤖 Generated with Claude Code