Repository navigation
Fix Meta with escape sequences (e.g. Meta+Up) - #48
Merged
Merged
Conversation
Terminals send Meta+key as ESC followed by the key, so Meta+Up is `ESC ESC [ A`. Since the esc delay support, `setMetaRoutine` parsed the escape sequence after the second ESC with `escRoutine` but discarded the result, and then dispatched the second ESC again: Meta+Up and other Meta+special-key combinations were not recognized, and the rest of the sequence was misinterpreted. Return the result of `escRoutine`, as it was before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alexey-milovidov
added a commit
to ClickHouse/ClickHouse
that referenced
this pull request
Oct 13, 2026
The previous `replxx` commit had a regression from the esc delay support in `replxx` `master`: Meta with escape sequences (e.g. Meta+Up) was not recognized, and `04909_client_hints_history_navigation` (`meta_up_recall_no_hints`) failed in every stateless test job: https://s3.amazonaws.com/clickhouse-test-reports/praktika.html?PR=125510&sha=33773832dc78e5a5e773171f8b489ca21d9bd77a&name_0=PR&name_1=Stateless%20tests%20%28arm_binary%2C%20parallel%29 #125510 The new commit is current `replxx` `master` (which also has the UTF-8 decoder state kept per `Terminal` from ClickHouse/replxx#47) plus the fix. Related: ClickHouse/replxx#48 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alexey-milovidov
added a commit
to spinojara/ClickHouse
that referenced
this pull request
Oct 13, 2026
The previous `replxx` commit had a regression from the esc delay support: Meta with escape sequences (e.g. Meta+Up) was not recognized, which breaks `04909_client_hints_history_navigation` (`meta_up_recall_no_hints`). The new commit is current `replxx` `master` plus the fix. Related: ClickHouse/replxx#48 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alexey-milovidov
added a commit
to spinojara/ClickHouse
that referenced
this pull request
Oct 13, 2026
Points the submodule to the merge commit of ClickHouse/replxx#48 on `master`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alexey-milovidov
added a commit
to ClickHouse/ClickHouse
that referenced
this pull request
Oct 13, 2026
The same tree as the previous `replxx` commit, now merged into `replxx` `master` via ClickHouse/replxx#48. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terminals send Meta+key as ESC followed by the key, so Meta+Up is
ESC ESC [ A.Since the esc delay support (
ef93b95),setMetaRoutineparses the escape sequence after the second ESC withescRoutine, but discards the result and then dispatches the second ESC again. As a result, Meta+Up and other Meta+special-key combinations are not recognized, and the rest of the sequence is misinterpreted.This returns the result of
escRoutine, as before. When an esc delay is set and runs out after the second ESC,escRoutinestill returns ESC.This made the ClickHouse test
04909_client_hints_history_navigation(casemeta_up_recall_no_hints) fail in every stateless test job of ClickHouse/ClickHouse#125510, which pins replxxmaster:https://s3.amazonaws.com/clickhouse-test-reports/praktika.html?PR=125510&sha=33773832dc78e5a5e773171f8b489ca21d9bd77a&name_0=PR&name_1=Stateless%20tests%20%28arm_binary%2C%20parallel%29
With this change, the test passes locally, as do the other interactive client tests.
🤖 Generated with Claude Code