Repository navigation
Conversation
`poll` reports `POLLNVAL` immediately when a watched fd has been closed or otherwise become invalid (for example, after a PTY teardown). The previous masks only covered `POLLIN | POLLHUP | POLLERR`, so neither branch fired and the `while (true)` loop spun at 100% CPU. Add `POLLNVAL` to the mask so the invalid fd is treated the same as a terminal/error condition - we read what we can from the interrupt pipe or surface a key-press event for the input fd, which lets the caller unwind cleanly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pollreportsPOLLNVALimmediately when a watched fd has been closed or otherwise become invalid (for example, after a PTY teardown). The previous masks only coveredPOLLIN | POLLHUP | POLLERR, so neither branch fired and thewhile (true)loop spun at 100% CPU. AddPOLLNVALto the mask so the invalid fd is treated the same as a terminal/error condition - we read what we can from the interrupt pipe or surface a key-press event for the input fd, which lets the caller unwind cleanly.