Skip to content

Mobile web UI [5/7]: Give notification body text the width of its card #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pufit merged 1 commit into from
Aug 10, 2026
Merged

Mobile web UI [5/7]: Give notification body text the width of its card #297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions web/src/pages/NotificationsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,10 +194,17 @@ function NotificationCard({ notif }: { notif: Notification }) {
<div className={`p-4 bg-surface border rounded-lg transition-colors ${
notif.status === 'pending' ? 'border-border-subtle' : 'border-border-subtle'
}`}>
<div className="flex items-start justify-between gap-3">
<div className="min-w-0 flex-1">
<div className="flex items-center gap-2">
{priorityDot && <span className={`w-2 h-2 rounded-full shrink-0 ${priorityDot}`} />}
{/* The badge column is shrink-0, so beside the text it costs a fixed
~127px — over a third of the card on a phone, which left the body
wrapping at ~190px. Below `sm` the badges take a row of their own
above the title instead, and the text gets the full card width. */}
<div className="flex flex-col sm:flex-row sm:items-start sm:justify-between gap-2 sm:gap-3">
<div className="min-w-0 flex-1 order-1 sm:order-none">
{/* items-start, not items-center: a title long enough to wrap was
centring the priority dot against the whole block, leaving it
floating beside the second line. */}
<div className="flex items-start gap-2">
{priorityDot && <span className={`w-2 h-2 mt-1.5 rounded-full shrink-0 ${priorityDot}`} />}
<h3 className="font-medium text-[15px] text-text">{notif.title}</h3>
</div>
{notif.body && (
Expand All @@ -209,7 +216,7 @@ function NotificationCard({ notif }: { notif: Notification }) {
</p>
)}
</div>
<div className="flex items-center gap-2 text-[12px] shrink-0">
<div className="flex flex-wrap items-center gap-2 text-[12px] shrink-0 order-0 sm:order-none">
{(notif.redelivery_count ?? 0) > 0 && (
<span
className="flex items-center gap-1 px-2 py-0.5 rounded-full border bg-sky-400/10 text-hue-blue border-sky-400/20"
Expand Down Expand Up @@ -516,7 +523,7 @@ export function NotificationsPage() {
}
/>

<div className="flex-1 overflow-y-auto p-6">
<div className="flex-1 overflow-y-auto p-4 md:p-6">
{showSilences && <SilencesPanel />}
{loading ? (
<div className="text-text-faint text-center py-10">Loading...</div>
Expand Down
2 changes: 1 addition & 1 deletion web/src/pages/PlansPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export function PlansPage() {
))}
/>

<div className="flex-1 overflow-y-auto p-6">
<div className="flex-1 overflow-y-auto p-4 md:p-6">
{loading ? (
<div className="text-text-faint text-center py-10">Loading...</div>
) : plans.length === 0 ? (
Expand Down
2 changes: 1 addition & 1 deletion web/src/pages/TasksPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ export function TasksPage() {
// and no max-width — filling the viewport is the whole point.
<TaskBoard onOpenTask={openTask} />
) : (
<div className="flex-1 overflow-y-auto p-6">
<div className="flex-1 overflow-y-auto p-4 md:p-6">
{loading ? (
<div className="text-text-faint text-center py-10">Loading...</div>
) : tasks.length === 0 ? (
Expand Down
Loading