Skip to content

Keep local install workflow triggers aligned - #512

Open
sdairs wants to merge 3 commits into
issue-479-local-server-state-machine-testsfrom
issue-461-install-workflow-classifier
Open

Keep local install workflow triggers aligned#512
sdairs wants to merge 3 commits into
issue-479-local-server-state-machine-testsfrom
issue-461-install-workflow-classifier

Conversation

@sdairs

@sdairs sdairs commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Replace the broad local install workflow filter with an exact mapping of installer-affecting source, subprocess test, manifest, lockfile, toolchain, and workflow paths.
  • Keep unrelated local and Postgres-only files explicitly classified out while covering shared dispatch, output, HTTP, path, server-discovery, and inherited version-manager dependencies.
  • Add a fail-closed inventory test, run by both the broad CLI workflow and install workflow, so new or renamed non-Cloud CLI Rust and subprocess test files require an explicit mapping decision.

Tests

  • python3 -m unittest discover -s scripts/tests -p 'test_*.py'
  • cargo test -p clickhousectl
  • cargo fmt --all --check
  • cargo clippy -p clickhousectl --all-targets -- -D warnings
  • Ruby YAML parsing for .github/workflows/test-cli.yml and .github/workflows/test-install.yml

Stack

Closes #461

Stack created with GitHub Stacks CLIGive Feedback

@sdairs sdairs changed the title issue 461 install workflow classifier Keep local install workflow triggers aligned Aug 24, 2026
@sdairs
sdairs force-pushed the issue-461-install-workflow-classifier branch from 962c55c to b52e2e2 Compare August 25, 2026 12:11
@sdairs
sdairs changed the base branch from issue-462-install-errors-help to issue-479-local-server-state-machine-tests August 25, 2026 12:13
@macroscopeapp

macroscopeapp Bot commented Aug 25, 2026

Copy link
Copy Markdown

Macroscope has since reviewed this pull request. An earlier review was skipped by a cost limit; a review has now completed, so that notice no longer applies.

@sdairs
sdairs force-pushed the issue-461-install-workflow-classifier branch from b52e2e2 to 828f02d Compare August 25, 2026 20:56

@iskakaushik iskakaushik left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdairs
sdairs force-pushed the issue-461-install-workflow-classifier branch from 828f02d to c175171 Compare August 26, 2026 09:28

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c175171. Configure here.

Comment thread scripts/classify-install-integration.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep local install integration workflow triggers aligned with installer dependencies

2 participants