Skip to content

Allow direct local client connections to select a binary version - #500

Closed
sdairs wants to merge 2 commits into
issue-466-local-client-selectorsfrom
issue-469-direct-client-version
Closed

Allow direct local client connections to select a binary version#500
sdairs wants to merge 2 commits into
issue-466-local-client-selectorsfrom
issue-469-direct-client-version

Conversation

@sdairs

@sdairs sdairs commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add direct-only local client --version <exact-installed-version> binary selection without changing the configured default
  • retain default-only resolution when direct --version is omitted, with no zero/one/multiple-install guessing and actionable missing/stale errors
  • preserve named-server metadata version selection and document connection selection separately from local binary selection
  • cover the parser and subprocess default/installed/explicit-version matrices

Closes #469

Verification

  • cargo fmt --all --check
  • cargo build -p clickhousectl
  • cargo test -p clickhousectl (756 passed)
  • cargo clippy -p clickhousectl --all-targets -- -D warnings

Stack

@sdairs sdairs changed the title Allow direct client binary selection Allow direct local client connections to select a binary version Aug 24, 2026
@sdairs
sdairs force-pushed the issue-469-direct-client-version branch from 15418a6 to ffaf4cb Compare August 25, 2026 12:11
@sdairs

sdairs commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator Author

good but adds too much noise to agent context help. it is unlikely that thorough explanation of a --version flag is needed beyond the actual flag description

@sdairs

sdairs commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator Author

Addressed in 30c6f10: removed the redundant --version explanation from agent-context help, restored the existing concise connection/default wording, and retained the flag and its description. Verified with the focused help test, the local client selector integration suite, cargo fmt --all --check, cargo check -p clickhousectl, and clippy with warnings denied.

@iskakaushik iskakaushik left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdairs
sdairs force-pushed the issue-466-local-client-selectors branch from e3c74bc to ba18c61 Compare August 25, 2026 22:01
@sdairs
sdairs force-pushed the issue-469-direct-client-version branch from 30c6f10 to 67fbcf3 Compare August 25, 2026 22:01
@sdairs

sdairs commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by #552 in stack #563.

@sdairs sdairs closed this Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow direct local client connections to select a binary version

2 participants