Skip to content

Bound and classify local version-manager network operations - #496

Open
sdairs wants to merge 6 commits into
issue-463-parse-version-operandsfrom
issue-459-version-network-bounds-v2
Open

Bound and classify local version-manager network operations#496
sdairs wants to merge 6 commits into
issue-463-parse-version-operandsfrom
issue-459-version-network-bounds-v2

Conversation

@sdairs

@sdairs sdairs commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Bound version resolution, build listing, master checks, and streamed downloads with explicit connect, read, and total operation deadlines through the shared HTTP client.
  • Classify failures by stage, host, and stable status category; treat only build-probe 403/404 as expected fallback and preserve the original unexpected probe failure when fallback also fails.
  • Retry installer downloads at most three times for transport, timeout, 429, and 5xx failures, honoring Retry-After within a five-second backoff cap.

Tests

  • cargo test -p clickhousectl version_manager (95 passed)
  • cargo test -p clickhousectl (all passed)
  • cargo fmt --all --check
  • cargo clippy -p clickhousectl --all-targets -- -D warnings

Stack

Closes #459

@sdairs sdairs changed the title issue 459 version network bounds v2 Bound and classify local version-manager network operations Aug 24, 2026
Comment thread crates/clickhousectl/src/version_manager/network.rs
Comment thread crates/clickhousectl/src/version_manager/list.rs
Comment thread crates/clickhousectl/src/version_manager/network.rs Outdated
Comment thread crates/clickhousectl/src/version_manager/resolve.rs
Comment thread crates/clickhousectl/src/version_manager/network.rs

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 39457ac. Configure here.

Comment thread crates/clickhousectl/src/version_manager/resolve.rs
Comment thread crates/clickhousectl/src/version_manager/list.rs
@sdairs
sdairs force-pushed the issue-459-version-network-bounds-v2 branch from 1fa8593 to edeac8d Compare August 25, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bound and classify local version-manager network operations

1 participant