Make PostgreSQL ClickPipe TLS failures actionable - #494
Open
sdairs wants to merge 2 commits into
Open
Conversation
|
|
||
| - Make the source reachable from ClickPipes and allow the [ClickPipes static IPs](https://clickhouse.com/docs/integrations/clickpipes/networking/static-ips) for your service region. | ||
| - Enable logical replication on PostgreSQL. | ||
| - Create a publication that includes every source table passed with `--table-mapping`. |
There was a problem hiding this comment.
🟠 High README.md:816
The PostgreSQL examples omit --publication-name, so following these instructions can make pipe creation enter the API's auto-create path and fail for users who only granted the documented schema, table, and replication privileges (or use a different publication). Add --publication-name <created-name> to both examples, or document the additional CREATE/ownership permissions required for auto-creation.
🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file @README.md around line 816:
The PostgreSQL examples omit `--publication-name`, so following these instructions can make pipe creation enter the API's auto-create path and fail for users who only granted the documented schema, table, and replication privileges (or use a different publication). Add `--publication-name <created-name>` to both examples, or document the additional `CREATE`/ownership permissions required for auto-creation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--ca-certificate/--tls-hostbehavior in command helpVerification
cargo test -p clickhousectl cloud::clickpipes::tests(44 passed)cargo test -p clickhousectl --test cli_request_shape_test postgres_(26 passed)cargo fmt --all --checkcargo clippy -p clickhousectl --all-targets -- -D warningscargo test -p clickhousectl(748 passed)Stack
Position: 2 of 2. Based on #484 (
issue-449-postgres-clickpipe-validation); that parent remains unchanged.Closes #446