Repository navigation
Conversation
Insert() built its own Query and always sent it with empty settings, so per-insert settings such as insert_deduplication_token or async_insert could not be used with native-format inserts. Closes ClickHouse#565
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #565
Client::Insert()built its ownQueryand sent it with empty settings, so per-insert settings likeinsert_deduplication_tokenorasync_insertcould not be used with native-format inserts.This adds two overloads:
The existing overloads are unchanged and send no settings.
BeginInsert(const Query&), which the issue also mentions, already sends the fullQueryon master, so it needed no change. The new test covers it.Test:
ClientCase.InsertWithQuerySettingscreates a MergeTree table withnon_replicated_deduplication_windowand checks that identical blocks are deduplicated without a token or with a repeated token, and kept with different tokens, through bothInsert()andBeginInsert(). It also checks that an unknownIMPORTANTsetting throwsServerException.The README's async-insert section no longer lists native
Insert()as unsupported.