Validate Decimal precision and scale before swapping - #553
Merged
slabko merged 2 commits intoAug 24, 2026
Conversation
slabko
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
ColumnDecimal::Swap()swaps the backing column.ValidationErrorwhen either value differs.Why?
ColumnDecimalcaches the backing storage type and keeps the scale in its type. Swapping columns with different precision or scale can make the backing data and metadata disagree.Tests
./build/ut/clickhouse-cpp-ut --gtest_filter="ColumnsCase.DecimalSwap*"./build/ut/clickhouse-cpp-ut --gtest_filter="ColumnsCase.*"Related to #552