Repository navigation
Fix Clang CFI violations in Flight and the C data interface helpers - #92
Merged
Merged
Conversation
…ucts `WritePayload` and `ReadPayload` passed a `FlightPayload` or `internal::FlightData` to gRPC as a `pb::FlightData` through `reinterpret_cast`, and `SerializationTraits<pb::FlightData>` cast it back. The object is not a `pb::FlightData`, which is undefined behavior and which Clang CFI (`-fsanitize=cfi-unrelated-cast`) rejects. gRPC only passes the message to `SerializationTraits`, so give it an empty, real `pb::FlightData` that sits next to a pointer to the Arrow struct, and read the struct back from it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The release callback of an `ArrowSchema` or `ArrowArray` can be implemented outside the code built with Clang CFI, for example in another language such as Rust. It then has no CFI type, so `ArrowSchemaRelease` and `ArrowArrayRelease` cannot check the call. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks for opening a pull request! This pull request has been automatically converted to a draft because its title doesn't match Arrow's required format. If this is not a minor PR, could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or After updating the title, you can mark the pull request as ready for review. See also: |
Algunenano
merged commit Nov 10, 2026
26706cf
into
ClickHouse/apache-arrow-25.0.0
36 of 91 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Two changes needed to build Arrow with Clang CFI.
WritePayloadandReadPayloadin the Flight gRPC transport passed aFlightPayloadorinternal::FlightDatato gRPC as apb::FlightDatathroughreinterpret_cast, andSerializationTraits<pb::FlightData>cast it back. The object is not apb::FlightData, which is undefined behavior and which Clang CFI (-fsanitize=cfi-unrelated-cast) rejects. They now give gRPC an empty, realpb::FlightDatathat sits next to a pointer to the Arrow struct, and the traits read the struct back from it. The same change is proposed upstream: apache#55480The release callback of an
ArrowSchemaorArrowArraycan be implemented outside the code built with Clang CFI, for example in Rust, and then has no CFI type.ArrowSchemaReleaseandArrowArrayReleaseare exempted fromcfi-icallfor that call. This one stays local.